Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Critical] Opera 109: This extension may have been corrupted #2765

Closed
lagun opened this issue Mar 27, 2024 · 14 comments
Closed

[Critical] Opera 109: This extension may have been corrupted #2765

lagun opened this issue Mar 27, 2024 · 14 comments

Comments

@lagun
Copy link

lagun commented Mar 27, 2024

The original issue text was changed by AdGuard. We'll be keeping it up to date.

What we know so far:

  1. After publishing version 4.3.31, Opera 109 fails to run it with the error This extension may have been corrupted
  2. The issue must have something to do with Opera Add-ons.
  3. AdGuard team tries to contact Opera asap about the issue.
  4. The extension works okay in Opera 108, the issue occurs with Opera 109 only.
  5. If you copy the extension from Opera Add-ons and install it as unpacked extension everything will work okay.
  6. Opera logs suggest that the browser fails to download extension's checksum from Opera Add-ons server.

At this point we think the problem is with Opera Add-ons, waiting for new information from them.

Temporary solution

Install AdGuard from Chrome WebStore.

@ameshkov
Copy link
Member

ameshkov commented Mar 27, 2024

It seems that Opera Add-ons corrupted the extension build, the manifest is different.

The problem is with this line (<all_urls> is corrupted):

"permissions": [ "tabs", "\u003Call_urls>", "webRequest", "webRequestBlocking", "webNavigation", "storage", "unlimitedStorage", "contextMenus", "cookies" ],

We're trying to contact Opera asap.

UPD: No, it's not permissions. If I just grab the unpacked extension downloaded from Opera - I can install it just okay. So the problem is probably with the key field.

@maximtop
Copy link
Contributor

Additionally, I'd like to mention that the extension installed from the Chrome Web Store is working as expected. Similarly, the extension in Opera v108 is also functioning properly.

@ameshkov ameshkov changed the title [Critical] This extension may have been corrupted. [Critical] Opera 109: This extension may have been corrupted Mar 27, 2024
@ameshkov
Copy link
Member

We've updated the issue text and explained the current situation.

We'll be keeping the issue text up-to-date and continue our attempts to contact Opera.

@maximtop
Copy link
Contributor

According to the logs from Opera, it seems that the extension can't be verified because it's unable to download the verified_contents.json file.
Here are the relevant log entries:

[81718:41987:0327/192351.956435:VERBOSE1:content_hash_fetcher.cc(43)] URLFetchComplete for bopfaehpakahokaelnomggbohfbimcia is_success:0 https://addons.opera.com/extensions/api/content-verification/1.0/signed-contents/bopfaehpakahokaelnomggbohfbimcia/4.3.31/
[81718:41987:0327/192351.956505:ERROR:content_hash.cc(255)] Fetching verified_contents.json for extension id: bopfaehpakahokaelnomggbohfbimcia version: 4.3.31 failed with error code 404

@ameshkov
Copy link
Member

Mentioning people from @operasoftware since this issue looks critical enough.

@avl7771 @psliwka @r4fek if anyone of you is reading this, please pass the message to the people responsible for the Add-ons store. We're having thousands new users with a broken ad blocker every minute.

@r4fek
Copy link

r4fek commented Mar 27, 2024

We will look into this, thanks for reporting.

@ameshkov
Copy link
Member

@r4fek thank you!

Just in case maybe this is useful info, I suppose the root cause is this URL:

v4.3.31, 404 Not Found:
https://addons.opera.com/extensions/api/content-verification/1.0/signed-contents/bopfaehpakahokaelnomggbohfbimcia/4.3.31/

Previous version, v4.3.14, 200 OK:
https://addons.opera.com/extensions/api/content-verification/1.0/signed-contents/bopfaehpakahokaelnomggbohfbimcia/4.3.14/

@avl7771
Copy link

avl7771 commented Mar 27, 2024

@ameshkov @lagun Thank you for the report. Some important context for the impact: Opera 109 is a beta version, and the number of users using it is many times less than for our stable version. If the bug isn't visible in Opera 108, it means the grand majority of users (>99%) hopefully don't get to see the problem.

We'll make sure Opera 109 doesn't go stable before the issue is solved.

@ameshkov
Copy link
Member

ameshkov commented Mar 27, 2024

@avl7771 hmm, it seems to be stable on macOS already, at least this is what I got when installed Opera from the website.

About Opera screenshot

image

Anyways, if i's still in beta on Windows the impact is much smaller than we thought at first, thanks for the information!

@avl7771
Copy link

avl7771 commented Mar 27, 2024

@ameshkov you're right, sorry, it was released but not sent as an automatic update yet - that means that new users get it and existing users if they explicitly update, so definitely more users, but still no big numbers.

Can you confirm you can see the problem on this version, 109.0.5097.33?

@ameshkov
Copy link
Member

@avl7771 got it, thank you!

Can you confirm you can see the problem on this version, 109.0.5097.33?

Yes, I can.

Looks like this:

image

Clicking "Repair" does not help.

In the browser logs we see that it cannot download https://addons.opera.com/extensions/api/content-verification/1.0/signed-contents/bopfaehpakahokaelnomggbohfbimcia/4.3.31/

[81718:41987:0327/192351.956435:VERBOSE1:content_hash_fetcher.cc(43)] URLFetchComplete for bopfaehpakahokaelnomggbohfbimcia is_success:0 https://addons.opera.com/extensions/api/content-verification/1.0/signed-contents/bopfaehpakahokaelnomggbohfbimcia/4.3.31/
[81718:41987:0327/192351.956505:ERROR:content_hash.cc(255)] Fetching verified_contents.json for extension id: bopfaehpakahokaelnomggbohfbimcia version: 4.3.31 failed with error code 404

@ameshkov
Copy link
Member

Yay, updating to v4.3.35 helped 🎉

This update was not released according to the schedule, but the main thing is it helped :)

@ameshkov
Copy link
Member

@avl7771 @r4fek thank you for helping with this so fast!

@avl7771
Copy link

avl7771 commented Mar 27, 2024

No problem, thanks for the quick report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants