Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox e10s issue #3

Closed
ameshkov opened this issue Jul 13, 2015 · 4 comments
Closed

Firefox e10s issue #3

ameshkov opened this issue Jul 13, 2015 · 4 comments
Assignees
@adguard
Labels
Bug
Milestone
2.0.13

Comments

@ameshkov
Copy link
Member

Adguard cannot detect the main frame while FF is working in e10s mode.

More info about that issue here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1108827

With current shims implementation I don't see a proper way to fix that.

Workaround:
As we now cannot get DOMWindow and detect iframes, we change recording of the main frame (do not allow to change main frame until 3 seconds has passed).
@ameshkov
Copy link
Member Author

Update on this issue:
We should track main frames in shouldLoad.

The problem here is that shouldLoad is not called for some requests (like websites opened from speed dial). In these rare cases we should track main frames in "http-on-examine-response".

@ameshkov ameshkov added this to the 2.0.13 milestone Jul 14, 2015
@ameshkov ameshkov added the Bug label Jul 14, 2015
ameshkov added a commit that referenced this issue Jul 14, 2015
@ameshkov
Updated version to 2.0.13
b1c4125 
Firefox: fixed incompatibility with e10s
#3
Firefox: fixed unsafe CPOW usage issue, addon should be much faster with e10s now
#4
Refactoring, some minor improvements
@ameshkov
Copy link
Member Author

Fixed:
b1c4125

@ameshkov
Copy link
Member Author

This fix breaks work in PaleMoon.

Problem: getTabForBrowser is available since FF 35 only.

@ameshkov ameshkov reopened this Jul 16, 2015
ameshkov added a commit that referenced this issue Jul 16, 2015
@ameshkov
Fixed some bugs
9e24a5a 
#3
#14
#2
@ameshkov
Copy link
Member Author

Fixed:
9e24a5a

Mizzick added a commit that referenced this issue Aug 31, 2017
@Mizzick
Merge pull request #3 in EXTENSIONS/browser-extension from feature/is…
80a3528 
…sues/799 to feature/redesign

Squashed commit of the following:

commit 9eafd04
Merge: 7094e2f 5e5579f
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Wed Aug 23 16:19:06 2017 +0300

    Merge remote-tracking branch 'origin/feature/redesign' into feature/issues/799

    # Conflicts:
    #	Extension/lib/filter/antibanner.js
    #	Extension/lib/filter/subscription.js
    #	Extension/lib/pages/options.js

commit 7094e2f
Merge: ae51894 810f381
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 17 17:55:21 2017 +0300

    Merge branch 'feature/issues/798' into feature/issues/799

commit 810f381
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 17 17:53:33 2017 +0300

    #798 filter tags

commit ae51894
Merge: a8e0b74 bd5052b
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 10 15:58:10 2017 +0300

    Merge branch 'feature/issues/798' into feature/issues/799

commit bd5052b
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 10 15:57:52 2017 +0300

    #798 filter tags presentation

commit a8e0b74
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 10 15:32:06 2017 +0300

    #799 Custom filters

commit 9c7564d
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 10 12:47:05 2017 +0300

    #799 Custom filters

commit 0fc34ad
Merge: ec7d661 bb00fd6
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 10 12:27:50 2017 +0300

    Merge branch 'feature/issues/798' into feature/issues/799

commit bb00fd6
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 10 12:26:51 2017 +0300

    #798 filter tags presentation

commit 70f153e
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Wed Aug 9 18:29:02 2017 +0300

    #798 filter tags presentation

commit ec7d661
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Wed Aug 2 22:09:22 2017 +0300

    #799 Custom filters
@aspasskaya aspasskaya mentioned this issue Feb 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adguard adguard

Labels
Bug
Projects
None yet
Milestone
2.0.13
Development

No branches or pull requests
2 participants
@ameshkov @adguard