Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $generichide modifier support #31

Closed
ameshkov opened this issue Sep 29, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@ameshkov
Copy link
Member

commented Sep 29, 2015

@ameshkov ameshkov added this to the 2.1 milestone Sep 29, 2015

@Mizzick

This comment has been minimized.

Copy link
Contributor

commented Oct 13, 2015

fixed

@Mizzick Mizzick closed this Oct 13, 2015

@atropnikov atropnikov reopened this Oct 14, 2015

@atropnikov

This comment has been minimized.

Copy link
Member

commented Oct 14, 2015

$generichide modifier not handled in Firefox extension, when css rules are registered via styleService.loadUserSheetByUri

@Mizzick Mizzick closed this Oct 15, 2015

@ameshkov

This comment has been minimized.

Copy link
Member Author

commented Oct 23, 2015

Rules should be considered as generic ONLY if there is no "permittedDomains" restrictions.

Examples below.

Generic

###banner
~google.com,~yahoo.com###banner

Not Generic

google.com###banner

Mizzick added a commit that referenced this issue Oct 23, 2015

Mizzick added a commit that referenced this issue Oct 23, 2015

@Mizzick

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2015

fixed

@gshumihin

This comment has been minimized.

Copy link

commented Dec 18, 2015

If "send statisticks" option is on, in firefox works incorrect
Steps to reproduce:

  1. Visit lenta.ru
  2. Add element hiding rule without domain restriction
  3. Add element hiding rule with domain restiction
  4. Add @@||lenta.ru^$generichide
    Expected result
  5. Element blocked by №2 unblocked
  6. Element blocked by №3 still blocked
    Real result:
  7. Element blocked by №2 still blocked
  8. Element blocked by №3 unblocked

@gshumihin gshumihin reopened this Dec 18, 2015

atropnikov added a commit that referenced this issue Dec 21, 2015

@atropnikov

This comment has been minimized.

Copy link
Member

commented Dec 21, 2015

fixed

@atropnikov atropnikov closed this Dec 21, 2015

Mizzick pushed a commit that referenced this issue Jan 11, 2018

Aleksandr Tropnikov
Merge pull request #31 in EXTENSIONS/browser-extension from feature/r…
…edesign-master-2.7.1 to feature/redesign

* commit '48eb5e968dd6899c3b8abad84a97d1a560428e97':
  Merge branch master into feature/redesign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.