Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$genericblock exceptions don't work until you restart Safari #508

Closed
vozersky opened this issue Jan 10, 2017 · 3 comments
Closed

$genericblock exceptions don't work until you restart Safari #508

vozersky opened this issue Jan 10, 2017 · 3 comments
Assignees

Comments

@vozersky
Copy link
Member

vozersky commented Jan 10, 2017

STR:

  1. Add:
    @@||4players.de^$genericblock

  2. Open http://www.4players.de/

  3. Check console.

image

  1. Restart Safari and check again, now the exception works.
@vozersky vozersky changed the title $genericblock exceptions don't work until browser restart in Safari $genericblock exceptions don't work until you restart Safari Jan 10, 2017
@atropnikov
Copy link
Member

After running the extension

[Info] 2017-01-11T09:36:52.168Z: Starting loading content blocker. (log.js, line 71)
[Info] 2017-01-11T09:36:52.252Z: Safari Content Blocker Converter v1.3.20 (log.js, line 71)
[Info] 2017-01-11T09:36:52.252Z: Converting 35101 rules. Optimize=false (log.js, line 71)
[Info] 2017-01-11T09:36:52.538Z: Applying 1036 css exceptions (log.js, line 71)
[Info] 2017-01-11T09:36:52.557Z: Css exceptions applied: 818 (log.js, line 71)
[Info] 2017-01-11T09:36:52.557Z: Css exceptions errors: 18 (log.js, line 71)
[Info] 2017-01-11T09:36:52.557Z: Trying to compact 13753 elemhide rules (log.js, line 71)
[Info] 2017-01-11T09:36:52.559Z: Compacted result: wide=22 domainSensitive=7671 (log.js, line 71)
[Info] 2017-01-11T09:36:52.559Z: Rules converted: 33705 (1396 errors) (log.js, line 71)
Basic rules: 13867
Elemhide rules (wide): 22
Elemhide rules (generic domain sensitive): 710
Exceptions Elemhide (wide): 573
Elemhide rules (domain-sensitive): 7671
Exceptions (elemhide): 193
Exceptions (other): 4265
[Info] 2017-01-11T09:36:52.570Z: Content blocker length: 27301 (log.js, line 71)
[Info] 2017-01-11T09:36:52.761Z: Setting content blocker. Length=27301 (log.js, line 71)
[Info] 2017-01-11T09:36:52.896Z: Content blocker has been set. (log.js, line 71)

After adding rule

@@||4players.de^$genericblock
[Info] 2017-01-11T09:37:18.563Z: Starting loading content blocker. (log.js, line 71)
[Info] 2017-01-11T09:37:18.652Z: Safari Content Blocker Converter v1.3.20 (log.js, line 71)
[Info] 2017-01-11T09:37:18.652Z: Converting 35102 rules. Optimize=false (log.js, line 71)
[Info] 2017-01-11T09:37:18.868Z: Applying 1036 css exceptions (log.js, line 71)
[Info] 2017-01-11T09:37:18.885Z: Css exceptions applied: 818 (log.js, line 71)
[Info] 2017-01-11T09:37:18.885Z: Css exceptions errors: 18 (log.js, line 71)
[Info] 2017-01-11T09:37:18.886Z: Trying to compact 13753 elemhide rules (log.js, line 71)
[Info] 2017-01-11T09:37:18.888Z: Compacted result: wide=22 domainSensitive=7671 (log.js, line 71)
[Info] 2017-01-11T09:37:18.888Z: Rules converted: 33705 (1397 errors) (log.js, line 71)
Basic rules: 13867
Elemhide rules (wide): 22
Elemhide rules (generic domain sensitive): 710
Exceptions Elemhide (wide): 572
Elemhide rules (domain-sensitive): 7671
Exceptions (elemhide): 193
Exceptions (other): 4266
[Info] 2017-01-11T09:37:18.902Z: Content blocker length: 27301 (log.js, line 71)
[Info] 2017-01-11T09:37:19.089Z: Setting content blocker. Length=27301 (log.js, line 71)
[Info] 2017-01-11T09:37:19.270Z: Content blocker has been set. (log.js, line 71)

@Mizzick
Copy link
Contributor

Mizzick commented Jan 16, 2017

Fixed with #510

@vozersky
Copy link
Member Author

Looks like it works fine now (2.5.11 Dev).

@vozersky vozersky added the Bug label Jan 16, 2017
@ameshkov ameshkov added this to the 2.5 Safari Hotfix milestone Jan 16, 2017
adguard pushed a commit that referenced this issue Sep 3, 2019
… to master

* commit 'a2c3e44ca82b3e3763b98ad2035c2fb99e6d9079':
  fix/1424 remove unnecessary class from element
  fix/1424 refactor log page, fix review notes
  fix/1424 add badfilter modifier to the domain level rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants