New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning Firefox data breaks Adguard extension #681

Closed
ameshkov opened this Issue May 9, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented May 9, 2017

Source:
#657 (comment)

@ameshkov ameshkov added this to the 2.6 milestone May 9, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 9, 2017

Member

@Anoop2609
Could you please be more specific about what actually is broken by clearing the browser cache & data?

Member

ameshkov commented May 9, 2017

@Anoop2609
Could you please be more specific about what actually is broken by clearing the browser cache & data?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 9, 2017

Member

I've just tried reproducing it FF 53, but everything seems to be okay.

Member

ameshkov commented May 9, 2017

I've just tried reproducing it FF 53, but everything seems to be okay.

@Anoop2609

This comment has been minimized.

Show comment
Hide comment
@Anoop2609

Anoop2609 May 10, 2017

Not okay in my pc, i simply clean cache of my firefox nothing else.
screenshot 14
screenshot 15
screenshot 16

Anoop2609 commented May 10, 2017

Not okay in my pc, i simply clean cache of my firefox nothing else.
screenshot 14
screenshot 15
screenshot 16

@Anoop2609

This comment has been minimized.

Show comment
Hide comment
@Anoop2609

Anoop2609 May 10, 2017

I am sorry, i did not mentions that you have to select everything while clearing cache, if you select any other option then adgurad works totally fine
screenshot 17

Anoop2609 commented May 10, 2017

I am sorry, i did not mentions that you have to select everything while clearing cache, if you select any other option then adgurad works totally fine
screenshot 17

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 10, 2017

Member

FF 52?

Member

ameshkov commented May 10, 2017

FF 52?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 10, 2017

Member

It looks like a FF bug, which I cannot reproduce in FF 53, so I guess it might've been fixed in FF 53 already.

Member

ameshkov commented May 10, 2017

It looks like a FF bug, which I cannot reproduce in FF 53, so I guess it might've been fixed in FF 53 already.

@Anoop2609

This comment has been minimized.

Show comment
Hide comment
@Anoop2609

Anoop2609 May 10, 2017

No, i am using latest FF 53.0.2(64 bit) and it is only happening with adguard 2.6.1 beta not with adguard 2.5.11 which is officially listed on firefox add-on site . I have also tons of other extension only adgurad gets affected.

Anoop2609 commented May 10, 2017

No, i am using latest FF 53.0.2(64 bit) and it is only happening with adguard 2.6.1 beta not with adguard 2.5.11 which is officially listed on firefox add-on site . I have also tons of other extension only adgurad gets affected.

atropnikov added a commit that referenced this issue May 10, 2017

atropnikov added a commit that referenced this issue May 12, 2017

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov May 14, 2017

Member

Actually AG uses extensions localStorage, which is also cleared when you choose to clear cookies.

Anyways, switching to another storage type should solve the issue:
https://github.com/AdguardTeam/AdguardBrowserExtension/pull/684/files

Member

ameshkov commented May 14, 2017

Actually AG uses extensions localStorage, which is also cleared when you choose to clear cookies.

Anyways, switching to another storage type should solve the issue:
https://github.com/AdguardTeam/AdguardBrowserExtension/pull/684/files

atropnikov added a commit that referenced this issue May 17, 2017

Merge pull request #684 from AdguardTeam/feature/issues/681-settings
Cleaning Firefox data breaks Adguard extension #681

@atropnikov atropnikov closed this May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment