Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning Firefox data breaks Adguard extension #681

Closed
ameshkov opened this issue May 9, 2017 · 8 comments
Closed

Cleaning Firefox data breaks Adguard extension #681

ameshkov opened this issue May 9, 2017 · 8 comments
Assignees
@atropnikov
Labels
Bug Firefox
Milestone
2.6

Comments

@ameshkov
Copy link
Member

ameshkov commented May 9, 2017

Source:
#657 (comment)
@ameshkov ameshkov added this to the 2.6 milestone May 9, 2017
@ameshkov
Copy link
Member Author

ameshkov commented May 9, 2017

@Anoop2609
Could you please be more specific about what actually is broken by clearing the browser cache & data?

@ameshkov ameshkov mentioned this issue May 9, 2017
Closed
@ameshkov
Copy link
Member Author

ameshkov commented May 9, 2017

I've just tried reproducing it FF 53, but everything seems to be okay.

@Anoop2609
Copy link

Not okay in my pc, i simply clean cache of my firefox nothing else.
screenshot 14
screenshot 15
screenshot 16

@Anoop2609
Copy link

I am sorry, i did not mentions that you have to select everything while clearing cache, if you select any other option then adgurad works totally fine
screenshot 17

@ameshkov
Copy link
Member Author

FF 52?

@ameshkov
Copy link
Member Author

It looks like a FF bug, which I cannot reproduce in FF 53, so I guess it might've been fixed in FF 53 already.

@Anoop2609
Copy link

Anoop2609 commented May 10, 2017 •
edited

No, i am using latest FF 53.0.2(64 bit) and it is only happening with adguard 2.6.1 beta not with adguard 2.5.11 which is officially listed on firefox add-on site . I have also tons of other extension only adgurad gets affected.

atropnikov added a commit that referenced this issue May 10, 2017
@atropnikov
https://github.com/AdguardTeam/AdguardBrowserExtension/issues/681
4edfd8a
@atropnikov atropnikov mentioned this issue May 10, 2017
Merged
atropnikov added a commit that referenced this issue May 12, 2017
@atropnikov
https://github.com/AdguardTeam/AdguardBrowserExtension/issues/681
265735b
@ameshkov
Copy link
Member Author

Actually AG uses extensions localStorage, which is also cleared when you choose to clear cookies.

Anyways, switching to another storage type should solve the issue:
https://github.com/AdguardTeam/AdguardBrowserExtension/pull/684/files

atropnikov added a commit that referenced this issue May 17, 2017
@atropnikov
Merge pull request #684 from AdguardTeam/feature/issues/681-settings
84179ca 
Cleaning Firefox data breaks Adguard extension #681
adguard pushed a commit that referenced this issue Oct 6, 2020
@maximtop
Pull request #681: enhance/AG-4483 refactor folders structure
ea3b669 
Merge in EXTENSIONS/browser-extension from enhance/AG-4483 to feature/AG-2737

* commit '10448bb91e05d3ed3bbe146036a26e30992b8bf9':
  AG-4483 fix tests
  AG-4483 refactor directories structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atropnikov atropnikov

Labels
Bug Firefox
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
3 participants
@atropnikov @ameshkov @Anoop2609