-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www.golem.de #139081
Comments
It was reviewed - the rule was removed. |
There is no |
Just a matter of adding plain CSS filter |
The submitter should not be blamed, the problem is caused by AdGuard list, hence submitted to AdGuard tracker, simple, the submitter was not digging into what the best solution is and on which list it should land, it might as well have turned out to be fixed in AdGuard Tracking Protection by excluding the domain (golem.de) or turned out to be some other issue and a different filter required, he left it for devs to determine. Also uBO's policy doesn't fix issues caused by AdGuard lists, why then EasyList Germany would fix such issues, do they fix issues caused by AdGuard lists. |
Without AdGuard Tracking Protection there are ads in these placeholders, and if these ads were filtered there would be no placeholders. |
I don't understand why you've tagged me here. This doesn't look like an issue belonging to any EasyList list, but to Adguard only, perhaps? To begin with, we had something similar to Also, I don't understand why according to you @gorhill, this issue should be fixed in EasyList Germany. It's not ELG fault here. |
Because you started update German version too. |
My bad, I mistakenly thought the placeholder was something not cosmetically removed in EasyList Germany, while it is. I thought these placeholders were the other ads I see on the page with Easylist Germany but not with AdGuard Germany: |
Maybe nasty self-promo to block first in Fanboy Annoyances? |
@zloyden we support uBlock Origin in AdGuard filters. When there's an issue reported from a uBO user we should fix it and not advise using other supplement lists or a different ad blocker. |
@gorhill I'd like to apologize, this was not the appropriate way to handle an issue. Are you aware of similar issues with AG filters? |
@zloyden in my comment the stress is on "not advise what was not asked for". |
Instead of removing AdGuard Tracking Protection from the filters entirely (i.e., deleting it), it should have been disabled and moved down to Custom rules. This is the way such things have been done in the past. Let users determine if they still want to use it, don't decide for them. That isn't user friendly. |
It will be moved on update all cache... On refresh (or patient wait to end update all lists) moved down to custom lists: Only on new configuration needed will be use filterlists.com (https://filterlists.com/lists/adguard-tracking-protection-filter-ublock-origin) or backup file (next stable uBo 1.46.2+). I don't see addition to badlists: https://github.com/uBlockOrigin/uAssets/blob/master/filters/badlists.txt |
Only if the list was already enabled/ticked/selected before updating all cache, otherwise, if it was unticked, it will be deleted then, which most likely (the latter) was the case for BlohoJo, I guess such logic: "moved if ticked, removed if unticked", is by intentional design: "why keeping something you weren't using anyway", unless rare cases when you temporarily have disabled the list and were unlucky when you realised it's gone next time you wanted to enable it or when you just installed a new fresh version of uBO: uBlockOrigin/uAssets#6803 (comment) |
Not added after your comment... |
There's probably a lot of context I'm missing out on about all this, but I suppose I can bring up the thoughts that come to my mind:
|
I think it's self-explanatory, one should read the thread carefully, to avoid misreading, the summary:
|
Removing this list fixed Microsoft Start page not showing images. The rule was blocking c.msn.com. I don't know why this list had to be removed from uBO for a few breaks |
Every filter list causes breakages from time to time (by the way some of breakages are caused by websites, not by filter lists, because something changes at website's side in an unexpected way), the crux is whether AdGuard Tracking Protection has been or not, causing overall more breakages than EasyPrivacy, it requires analysing issue trackers's history. From a single user perspective, as for me, AGTP list has not been causing more breakages than EasyPrivacy, but memory can fail, also other users' experiences might be different. |
I doubt in use " |
Maybe on |
So has anyone heard any updates on if uBlock Origin is going to add the AdGuard Tracking Protection list back among the default lists available? The longer this goes on, the worse it looks for AdGuard, in my opinion, some will assume that your list has problems & will avoid it; even if the decision to remove it & not add it back once this was fixed was a bit extreme. |
I doubt. |
All I know is that the creator of uBO is already back since several days, but as seen, doesn't bother to answer. |
Thanks, that is not a good sign. |
Adguard tracking protection was added back now: gorhill/uBlock@02dff78 |
Issue URL (Ads)
https://www.golem.de/
Comment
Username:
@felix-22
Screenshots
Screenshot 1
System configuration
AdGuard Base,
EasyList
Privacy:
AdGuard Tracking Protection,
EasyPrivacy,
Peter Lowe's Blocklist
Language-specific:
EasyList Germany
The text was updated successfully, but these errors were encountered: