Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.golem.de #139081

Closed
adguard-bot opened this issue Jan 3, 2023 · 29 comments
Closed

www.golem.de #139081

adguard-bot opened this issue Jan 3, 2023 · 29 comments
Assignees
Labels
A: In progress Work on the issue is in progress N: Other P2: High T: Ads

Comments

@adguard-bot
Copy link

Issue URL (Ads)

https://www.golem.de/

Comment

Username: @felix-22

This filter from Adguard Tracking Protection: ||cdn.stroeerdigitalgroup.de^$third-party causes an AD placeholder appearing on the main page (screenshoot 1), it can be proven by turning off Adguard Tracking Protection or disabling the filter by badfilter (||cdn.stroeerdigitalgroup.de^$third-party,badfilter), which fixes the AD placholder (screenshoot 2). Optionally: golem.de###iqadtile5 can bu used to hide the remaining AD placeholder.

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information value
Platform: uBlock Origin
Browser: Firefox
Filters: Ad Blocking:
AdGuard Base,
EasyList

Privacy:
AdGuard Tracking Protection,
EasyPrivacy,
Peter Lowe's Blocklist

Language-specific:
EasyList Germany
@zloyden zloyden added the A: In progress Work on the issue is in progress label Jan 9, 2023
@zloyden
Copy link
Contributor

zloyden commented Jan 9, 2023

It was reviewed - the rule was removed.

@zloyden zloyden closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2023
@garry-ut99
Copy link

garry-ut99 commented Jan 10, 2023

There is no AdGuard German in uBO regional filters, there is EasyList Germany instead, because adding AdGuard German into uBO was declined in the past due to some incompatibility issues: uBlockOrigin/uBlock-issues#379, thus one should not recommend turning it on for uBO users. Also no one informed before, that different filter lists are required to fix issues in AdGuard Tracking Protection list, as usually issues are fixed in the same list.

@gorhill
Copy link

gorhill commented Jan 10, 2023

Just a matter of adding plain CSS filter golem.de###screen div[id^="iqadtile"] to Easylist Germany -- this is really where the issue should have been submitted.

@garry-ut99
Copy link

garry-ut99 commented Jan 11, 2023

The submitter should not be blamed, the problem is caused by AdGuard list, hence submitted to AdGuard tracker, simple, the submitter was not digging into what the best solution is and on which list it should land, it might as well have turned out to be fixed in AdGuard Tracking Protection by excluding the domain (golem.de) or turned out to be some other issue and a different filter required, he left it for devs to determine. Also uBO's policy doesn't fix issues caused by AdGuard lists, why then EasyList Germany would fix such issues, do they fix issues caused by AdGuard lists.

@gorhill
Copy link

gorhill commented Jan 11, 2023

Without AdGuard Tracking Protection there are ads in these placeholders, and if these ads were filtered there would be no placeholders.

@krystian3w
Copy link
Contributor

krystian3w commented Jan 11, 2023

@monzta / @Khrin

@Khrin
Copy link

Khrin commented Jan 11, 2023

@Montza / @Khrin

I don't understand why you've tagged me here. This doesn't look like an issue belonging to any EasyList list, but to Adguard only, perhaps?

To begin with, we had something similar to ||cdn.stroeerdigitalgroup.de^$third-party in either EasyList Germany and EasyPrivacy, but the filters were ultimately removed because were causing several issues across different sites, so I don't understand why Adguard would use it as well.

Also, I don't understand why according to you @gorhill, this issue should be fixed in EasyList Germany. It's not ELG fault here.

@krystian3w
Copy link
Contributor

krystian3w commented Jan 11, 2023

Because you started update German version too.

@gorhill
Copy link

gorhill commented Jan 11, 2023

I don't understand why according to you @gorhill

My bad, I mistakenly thought the placeholder was something not cosmetically removed in EasyList Germany, while it is. I thought these placeholders were the other ads I see on the page with Easylist Germany but not with AdGuard Germany:

Screenshot from 2023-01-11 12-12-45

@krystian3w
Copy link
Contributor

krystian3w commented Jan 11, 2023

Maybe nasty self-promo to block first in Fanboy Annoyances?

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 12, 2023
Alex-302 added a commit that referenced this issue Jan 12, 2023
gorhill added a commit to gorhill/uBlock that referenced this issue Jan 12, 2023
@ameshkov
Copy link
Member

ameshkov commented Jan 12, 2023

@zloyden we support uBlock Origin in AdGuard filters. When there's an issue reported from a uBO user we should fix it and not advise using other supplement lists or a different ad blocker.

@ameshkov
Copy link
Member

@gorhill I'd like to apologize, this was not the appropriate way to handle an issue. Are you aware of similar issues with AG filters?

@zloyden
Copy link
Contributor

zloyden commented Jan 12, 2023

@ameshkov I know that, but it was an ad leftover (still is in the code and in rare case can be shown), that was fixed in AdGuard German in the past by @BlazDT .
However, I and @Alex-302 had discussed this case and fixed it - there is no that rule in AdGuard Tracking Protection.

@ameshkov
Copy link
Member

@zloyden in my comment the stress is on "not advise what was not asked for".

@BlohoJo
Copy link

BlohoJo commented Jan 14, 2023

Instead of removing AdGuard Tracking Protection from the filters entirely (i.e., deleting it), it should have been disabled and moved down to Custom rules. This is the way such things have been done in the past. Let users determine if they still want to use it, don't decide for them. That isn't user friendly.

@krystian3w
Copy link
Contributor

krystian3w commented Jan 14, 2023

It will be moved on update all cache...

obraz

On refresh (or patient wait to end update all lists) moved down to custom lists:

obraz

obraz

Only on new configuration needed will be use filterlists.com (https://filterlists.com/lists/adguard-tracking-protection-filter-ublock-origin) or backup file (next stable uBo 1.46.2+).

I don't see addition to badlists:

https://github.com/uBlockOrigin/uAssets/blob/master/filters/badlists.txt
https://github.com/uBlockOrigin/uAssets/commits/master/filters/badlists.txt

@garry-ut99
Copy link

garry-ut99 commented Jan 14, 2023

krystian3w: It will be moved on update all cache...

Only if the list was already enabled/ticked/selected before updating all cache, otherwise, if it was unticked, it will be deleted then, which most likely (the latter) was the case for BlohoJo, I guess such logic: "moved if ticked, removed if unticked", is by intentional design: "why keeping something you weren't using anyway", unless rare cases when you temporarily have disabled the list and were unlucky when you realised it's gone next time you wanted to enable it or when you just installed a new fresh version of uBO:

uBlockOrigin/uAssets#6803 (comment)
uBlockOrigin/uBlock-issues#14

@krystian3w
Copy link
Contributor

krystian3w commented Jan 14, 2023

Only on new configuration needed will be use filterlists.com

Not added after your comment...

@DandelionSprout
Copy link
Member

DandelionSprout commented Jan 14, 2023

There's probably a lot of context I'm missing out on about all this, but I suppose I can bring up the thoughts that come to my mind:

  1. uBlock Origin have seemed very strict about which international/Anglosphere lists to include since at least 2018, to the point one needs insider contacts to even have a slim hope of getting in (And even with insider contacts, I had Dandelion Sprout's Anti-Malware List and Legitimate URL Shortener rejected at least once each). If uBO from the looks of it want a slim (or even minimal) portfolio of non-regional included lists, then it doesn't surprise me that they'd remove lists very easily as well.
  2. Somewhat surprisingly, EasyList Germany is in fact also included in most AdGuard products, so Felix-22's listing of it in the OP was fair of him to do.
  3. www.golem.de #139081 (comment) looks like a clarification/apology to me, so I don't seem to understand his jump to removing the list 8 hours later with no further explanations of why.

@garry-ut99
Copy link

garry-ut99 commented Jan 14, 2023

DandelionSprout :

looks like a clarification/apology to me, so I don't seem to understand his jump to removing the list 8 hours later with no further explanations of why.

From what little I can figure out about the matter, I struggle quite a bit to understand Gorhill's logic there. After a confusion between AdGuard Tracking Protection and two German lists were sorted out and apologised for, Gorhill then responded by... removing Tracking Protection...??

I think it's self-explanatory, one should read the thread carefully, to avoid misreading, the summary:

  • the Golem issue was fixed in AdGuard German (despite the issue was caused by AdGuard Tracking Protection)
  • but uBO's users couldn't benefit of the fix in uBO due to incompatibility between uBO and AdGuard German (I'm not sure by whose fault) which resulted AdGuard Tracking Protection causing unfixed issues for uBO users
  • that's why AdGuard Tracking Protection was removed then I think/assume, as "incompatible" or "having incompatible dependencies"
  • but of course finally, afterwards, the Golem issue was fixed for uBO users in AdGuard Tracking Protection itself as well (7 hours later), so perhaps AdGuard Tracking Protection will be restored, unless there were other reasons which led to the removal
  • the uBO dev might be busy with other things currently, thus the best would be to wait for his reply and avoid flawed assumptions until then

@jawz101
Copy link

jawz101 commented Jan 19, 2023

Removing this list fixed Microsoft Start page not showing images. The rule was blocking c.msn.com. I don't know why this list had to be removed from uBO for a few breaks

@garry-ut99
Copy link

garry-ut99 commented Jan 19, 2023

Every filter list causes breakages from time to time (by the way some of breakages are caused by websites, not by filter lists, because something changes at website's side in an unexpected way), the crux is whether AdGuard Tracking Protection has been or not, causing overall more breakages than EasyPrivacy, it requires analysing issue trackers's history. From a single user perspective, as for me, AGTP list has not been causing more breakages than EasyPrivacy, but memory can fail, also other users' experiences might be different.

@krystian3w
Copy link
Contributor

#139081 (comment)

I doubt in use "||cdn.stroeerdigitalgroup.de^$third-party" by Microsoft portal.

@garry-ut99
Copy link

garry-ut99 commented Jan 20, 2023

Maybe on www.msn.com/de-de/feed

@goodjohnjr
Copy link

So has anyone heard any updates on if uBlock Origin is going to add the AdGuard Tracking Protection list back among the default lists available?

The longer this goes on, the worse it looks for AdGuard, in my opinion, some will assume that your list has problems & will avoid it; even if the decision to remove it & not add it back once this was fixed was a bit extreme.

@krystian3w
Copy link
Contributor

Maybe on www.msn.com/de-de/feed

I doubt.

@garry-ut99
Copy link

goodjohnjr: So has anyone heard any updates

All I know is that the creator of uBO is already back since several days, but as seen, doesn't bother to answer.

@goodjohnjr
Copy link

goodjohnjr: So has anyone heard any updates

All I know is that the creator of uBO is already back since several days, but as seen, doesn't bother to answer.

Thanks, that is not a good sign.

@peace2000
Copy link
Contributor

peace2000 commented May 19, 2023

Adguard tracking protection was added back now: gorhill/uBlock@02dff78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: In progress Work on the issue is in progress N: Other P2: High T: Ads
Projects
None yet
Development

No branches or pull requests