Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allmusic.com #4143

Closed
192848 opened this issue Jan 21, 2017 · 11 comments
Closed

allmusic.com #4143

192848 opened this issue Jan 21, 2017 · 11 comments
Assignees
Labels
T: Anti Adblock Script The site detects ad blocking

Comments

@192848
Copy link

192848 commented Jan 21, 2017

Description: allmusic.com
http://www.allmusic.com/album/hang-mw0002997485

Screenshot:

image

System configuration

Information value
Operating system: Windows
Browser: Chrome
Adguard version: 6.1.298.1564
Adguard driver (Windows): WFP
Adguard filters: 1,2,3,4,14,211

Ticket ID(if exists): 734231

@192848 192848 added the T: Anti Adblock Script The site detects ad blocking label Jan 21, 2017
@Alex-302
Copy link
Member

Alex-302 commented Jan 22, 2017

temporary solution for user

@@/(outbrain)|(taboola)|(doubleverify)|(adchoice)|(pubads)|(adsystem)|(\/adnexus-)|(\.openx\.)|(moatad)|(\/us-ads\.)|(adserver)|(1rx)|(safeframe)|(advert)|(revcontent)/$domain=allmusic.com
@@||c.amazon-adsystem.com/aax2/amzn_ads.js
@@||allmedia-d.openx.net/*/jstag?nc=*-SideReel

Requests 2 and 3 doesn't have referer.

@Alex-302
Copy link
Member

Alex-302 commented Jan 22, 2017

Added

||allmusic.com^$replace=/_0xe367/0xFFFF/,important

Alex-302 added a commit that referenced this issue Jan 22, 2017
@Alex-302
Copy link
Member

@seanl-adg Could you try to make JS rule?

@theseanl
Copy link
Contributor

theseanl commented Jan 23, 2017

@Alex-302

allmusic.com#%#(function(b){window.setTimeout=new Proxy(function(){},{apply:function(d,a,c){return/^function _0x[a-z0-9]{0,8}\([\s\S]*?_0x[a-z0-9]{0,8}\[_0x[a-z0-9]{0,8}\[\d+\]\]/.test(c[0].toString())?1:b.apply(a,c)},get:function(d,a){return"toString"==a?function(){this.toString=Function.prototype.toString;return b.toString()}:b[a]},set:function(d,a,c){b[a]=c}})})(window.setTimeout);

is working on my end.

@Alex-302
Copy link
Member

@seanl-adg it works:)

theseanl pushed a commit that referenced this issue Jan 23, 2017
@theseanl
Copy link
Contributor

@Alex-302 we need exception rules for Safari filter too

@@||allmedia-d.openx.net/*/jstag?nc=*-SideReel
@@||b.scorecardresearch.com/beacon.js^$domain=allmusic.com
@@/(doubleclick\.net\/trackimpj\/)|(doubleclick\.net\/ddm\/adj\/)/i$image,domain=allmusic.com
@@/(doubleclick\.net\/trackimp\/)|(doubleclick\.net\/ddm\/ad\/)/i$script,other,domain=allmusic.com
@@||tpc.googlesyndication.com/safeframe/$domain=allmusic.com

seems to be working on my end without JS rules. Could you check?

@Alex-302
Copy link
Member

Alex-302 commented Jan 27, 2017

on iOS it works without additional rules.
In safari on mac with this:

@@||securepubads.g.doubleclick.net/gpt/pubads_impl_$domain=allmusic.com

added it.

@ghajini
Copy link

ghajini commented Feb 28, 2017

issue is back on allmusic.com

@theseanl
Copy link
Contributor

theseanl commented Mar 2, 2017

@ghajini Hi, I was unable to reproduce the issue.
Please provide more information including what software and browser you are using, if you are still experiencing the issue.

@ghajini
Copy link

ghajini commented Mar 2, 2017

@seanl-adg
http://www.allmusic.com/newreleases/all

http://www.allmusic.com/newreleases

i get antiadblock notice on allmusic RANDOMLY like playing more music and surfing....
screenshot 155

adguard 2.5.11, all default filters
google chrome Version 56.0.2924.87 (64-bit)

@theseanl
Copy link
Contributor

theseanl commented Mar 2, 2017

@ghajini
Hi, I confirm that sometimes the detection shows up while using browser extensions.
However, this is due to the current limitation of Adguard browser extensions.
Adguard browser extensions cannot execute javascript injection rules early enough, and allmusic.com's anti-adblock script is located in an early part of the page, so sometimes their script runs first.
We don't have such limitations on standalone softwares. It will be improved in browser extensions when what's done in AdguardTeam/AdguardBrowserExtension#512 is shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Anti Adblock Script The site detects ad blocking
Projects
None yet
Development

No branches or pull requests

4 participants