Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate AdGuard Assistant into the Android app #1696

Closed
ameshkov opened this issue Jan 16, 2018 · 8 comments
Closed

Integrate AdGuard Assistant into the Android app #1696

ameshkov opened this issue Jan 16, 2018 · 8 comments

Comments

@ameshkov
Copy link
Member

ameshkov commented Jan 16, 2018

We've got it on iOS (in a simplified form) allowing to select & block any element on a page, so it'd doable. On Android, the only question is how to draw the Assistant so that it was usable and not too annoying.

I like how Samsung Internet's helper looks like:
https://uploads.adguard.com/up04_dfkun_Samsung-Internet-Review-01.jpg_43202220_.png

It's draggable, not too annoying, easy to remove. We should simply use the same style for the mobile Assistant.

@BlazDT
Copy link

BlazDT commented Nov 30, 2019

Any updates to this request?

@artemiv4nov
Copy link
Contributor

@BlazDT , Hi!
This task is in line for execution.

@ameshkov ameshkov modified the milestones: 3.5, 3.6 Dec 3, 2019
@ameshkov
Copy link
Member Author

ameshkov commented Dec 3, 2019

This is actually a duplicate of #2163

@ameshkov ameshkov closed this as completed Dec 3, 2019
@BlazDT
Copy link

BlazDT commented Dec 3, 2019

Since this ticket has ID 1696 which is less than the other, actually the opposite.

@ameshkov
Copy link
Member Author

ameshkov commented Dec 3, 2019

@BlazDT well yeah, you're right:) But the newer ticket contains the proper explanation of how we should try to implement this

@ghost
Copy link

ghost commented Nov 20, 2020

@ameshkov Do you have any UI mockups and the UX-flow available for this feature so that I can give feedback on the UX if needed? Drawing elements on the webpage on a mobile device doesn't seem like a good idea to me (like the Samsung Internet browser example in the #1696 (comment)). But again I don't have any better ideas. May be if I see it visually perhaps I may be able to give some suggestions.

@ameshkov
Copy link
Member Author

Well, I explained it in the new task: #2163

Using the "Sharing Provider" we could avoid drawing anything. You just share any link to AG, AG shows a dialog with a couple of options, for instance disabling/enabling protection for a website, reporting a website, etc.

@ghost
Copy link

ghost commented Nov 20, 2020

Oh, sorry. I didn't notice that this issue is already closed. I saw the proposal at #2163, It's a great solution since it completely avoids drawing anything on the webpage. Sorry for the interpretation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants