Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters labels' issues #2386

Closed
lancelot-moon opened this issue Dec 11, 2018 · 6 comments
Closed

Filters labels' issues #2386

lancelot-moon opened this issue Dec 11, 2018 · 6 comments
Assignees
Labels

Comments

@lancelot-moon
Copy link

lancelot-moon commented Dec 11, 2018

@ameshkov
@aalpatkina

  1. A wrong description for Bulgarian (bg) label.
    (Wrongly use the description of Indonesian language-specific ad blocking)
Screenshot:

image


  1. Lack the descriptions for Bulgarian on onesky.
    You need to add the below 2 new phrases on onesky.
    Bulgarian language-specific ad blocking
    Designed specifically to block ads on web pages in the Bulgarian language
    And use them for Bulgarian list filter. [Bulgarian (bg) label]

  2. Lack the label for ABPindo filter and need to use the correct description (Indonesian language-specific ad blocking).

Screenshot:

image


  1. Lack the "ru" label for RU AdList: Counters filter and RU AdList: BitBlock filter.
@ameshkov
Copy link
Member

Labels are loaded from the server periodically (rarely) from here: http://filters.adtidy.org/android/filters_i18n.json

We will update them eventually, but that's not a part of Android app.

Anyways, it needs to be taken care of @aalpatkina

@ameshkov
Copy link
Member

@aalpatkina plz close this issue once it's resolved on oneskyapp

@ameshkov
Copy link
Member

Regarding points 3 and 4, it needs to be resolved in https://github.com/AdguardTeam/FiltersRegistry

@Alex-302 plz assist

@aalpatkina
Copy link

resolved on Onesky platform

@lancelot-moon
Copy link
Author

@ameshkov
Yes, you had fixed the point 2, 3 and 4.
But the point 1 and ABPindo's issue (no description when clicking its tag) aren't fixed in AG v3.0.145η.

@ameshkov
Copy link
Member

@lancelot-moon we have not yet synced Android version with the server side. We will do it in one of the future versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants