Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.klook app to the default HTTPS filtering exclusions #5143

Closed
adguard-bot opened this issue Dec 17, 2023 · 25 comments
Closed

Add com.klook app to the default HTTPS filtering exclusions #5143

adguard-bot opened this issue Dec 17, 2023 · 25 comments

Comments

@adguard-bot
Copy link

Issue URL (Incorrect Blocking)

https://play.google.com/store/apps/details?id=com.klook

Comment

There are lots of apps show error after I enable Adguard

Examples:
https://play.google.com/store/apps/details?id=com.klook
https://play.google.com/store/apps/details?id=tw.com.thsrc.enterprise
https://play.google.com/store/apps/details?id=com.tplink.tpm5
etc
Please try to fix the problems
Username: @SunnyLeu

[NSFW] Screenshots

Screenshot 1

Screenshot 1

Screenshot 1 with AdGuard disabled

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for Android v4.2.118
System version: Android 13
Browser: Klook APP, please download and open
AdGuard mode: VPN
HTTPS filtering: enabled
Android system root: true
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Hide your Referrer from third-parties,
Hide your User-Agent,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (180),
Self-destructing first-party cookies (4320)
DNS filtering: server: https://dns.google/dns-query
filters: https://filters.adtidy.org/android/filters/15_optimized.txt
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads,
EasyList

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
Peter Lowe's Blocklist

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances,
AdGuard Other Annoyances,
AdGuard Mobile App Banners,
AdGuard Widgets,
AdGuard Cookie Notices,
AdGuard Popups,
Adblock Warning Removal List,
I don't care about cookies,
EasyList Cookie List

Security:
Online Malicious URL Blocklist,
NoCoin Filter List

Other:
AdGuard DNS,
Filter unblocking search ads and self-promotion

Language-specific:AdGuard Russian,
AdGuard German,
AdGuard Japanese,
AdGuard French,
AdGuard Spanish/Portuguese,
AdGuard Ukrainian,
AdGuard Chinese,
AdGuard Turkish,
AdGuard Dutch,
Official Polish filters for AdBlock, uBlock Origin & AdGuard,
EasyList China,
Macedonian adBlock Filters,
EasyList Italy,
EasyList Thailand,
Persian Blocker,
AdBlockID,
IndianList,
Hungarian,
Estonian List,
Frellwit's Swedish Filter,
List-KR,
EasyList Czech and Slovak,
EasyList Hebrew,
EasyList Lithuania,
ABPVN List,
Adblock List for Finland,
Bulgarian list,
Polish Anti Adblock Filters,
Liste AR,
Latvian List,
Dandelion Sprout's Nordic Filters
Custom filters: https://filter.futa.gg/removeparam.txt,
https://filter.futa.gg/hide_farm_from_search.txt,
https://filter.futa.gg/filter.txt
Userscripts: https://userscripts.adtidy.org/release/disable-amp/1.0/disable-amp.meta.js
https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js
@Alex-302
Copy link
Member

@SunnyLeu Hi. Sorry for the late reply.
Is it caused by filters? I see you have many enabled third-party filters, including custom.

@SunnyLeu
Copy link

SunnyLeu commented Dec 27, 2023

@SunnyLeu Hi. Sorry for the late reply. Is it caused by filters? I see you have many enabled third-party filters, including custom.

You can see this
AdguardTeam/AdguardFilters#169383
Here are the details
And "Disable all the protection, but keep AdGuard enable" means this:
Screenshot_20231228-011135_ASUS_Launcher
Notice that all the protection is gray, means disabled.
So I don't think it cause by filter.

@Alex-302 Alex-302 changed the title Google Play: com.klook com.klook app is broken by filtering Dec 28, 2023
@Alex-302
Copy link
Member

Ok. Thanks. Will move to corresponding repository.

@Alex-302 Alex-302 removed the P4: Low label Dec 28, 2023
@Alex-302 Alex-302 removed their assignment Dec 28, 2023
@Alex-302 Alex-302 transferred this issue from AdguardTeam/AdguardFilters Dec 28, 2023
@AdguardTeam AdguardTeam deleted a comment from github-actions bot Dec 28, 2023
@AdguardTeam AdguardTeam deleted a comment from SunnyLeu Dec 28, 2023
@AdguardTeam AdguardTeam deleted a comment from SunnyLeu Dec 28, 2023
@AdguardTeam AdguardTeam deleted a comment from github-actions bot Dec 28, 2023
@Alex-302
Copy link
Member

@SunnyLeu Please collect debug logs and send them to dev team like described here
https://adguard.com/kb/adguard-for-android/solving-problems/log/

@SunnyLeu
Copy link

@SunnyLeu Please collect debug logs and send them to dev team like described here https://adguard.com/kb/adguard-for-android/solving-problems/log/

Ok, I have sent an email to devteam@adguard.com according to the reply of #5135 (comment)

@SunnyLeu
Copy link

SunnyLeu commented Jan 5, 2024

any progress?

@Alex-302
Copy link
Member

Alex-302 commented Jan 5, 2024

We have the weekend off until January 8th:)

@adguard-bot adguard-bot assigned maxikuzmin and unassigned Versty Jan 10, 2024
@maxikuzmin
Copy link
Contributor

@SunnyLeu thanks for the wait. Could you please clarify on the detailed steps to replicate the problem? I tried this on my device, but there is no problem

@SunnyLeu
Copy link

@SunnyLeu thanks for the wait. Could you please clarify on the detailed steps to replicate the problem? I tried this on my device, but there is no problem

That's all the steps I have done, no other steps.

@maxikuzmin
Copy link
Contributor

@SunnyLeu so you just log into the app with protection enabled and the app shows an error?

it would be nice to get your logs.

  • Enable debug logging:

Settings -> General -> Advanced -> Logging level -> Debug

  • Reproduce the issue related to the button behaviour, then remember the exact time when it happened

  • Collect logs:

Settings -> General -> Advanced -> Export logs and system info

mention the 5143 number in the subject
specify the exact time when the issue occurred

@SunnyLeu
Copy link

@SunnyLeu so you just log into the app with protection enabled and the app shows an error?

it would be nice to get your logs.

  • Enable debug logging:

Settings -> General -> Advanced -> Logging level -> Debug

  • Reproduce the issue related to the button behaviour, then remember the exact time when it happened
  • Collect logs:

Settings -> General -> Advanced -> Export logs and system info

mention the 5143 number in the subject specify the exact time when the issue occurred

But I sent it before, at #5143 (comment)

@maxikuzmin
Copy link
Contributor

@SunnyLeu I apologize, but I don't see your logs in the post. Could you please duplicate sending the logs and mention the 5143 number in the subject specify the exact time when the issue occurred

@SunnyLeu
Copy link

@SunnyLeu I apologize, but I don't see your logs in the post. Could you please duplicate sending the logs and mention the 5143 number in the subject specify the exact time when the issue occurred

OK, email sent.

@SunnyLeu SunnyLeu mentioned this issue Jan 22, 2024
4 tasks
@SunnyLeu
Copy link

@maxikuzmin I just sent the new logs again, please check.

@maxikuzmin
Copy link
Contributor

@SunnyLeu thanks, I got your logs! It will take us some time to into it

@maxikuzmin
Copy link
Contributor

@SunnyLeu could you please specify the version number of the klook app?

@SunnyLeu
Copy link

@SunnyLeu could you please specify the version number of the klook app?

6.60.0 (6514)

@maxikuzmin
Copy link
Contributor

@SunnyLeu I tried to reproduce this case with your settings and with the same version of Klook, but I don't have this problem again.
I see you have root enabled, please try to disable HTTPS filtering. Is the problem still recurring?

@SunnyLeu
Copy link

@SunnyLeu I tried to reproduce this case with your settings and with the same version of Klook, but I don't have this problem again. I see you have root enabled, please try to disable HTTPS filtering. Is the problem still recurring?

OMG, problem solved, thank you so much.

@maxikuzmin
Copy link
Contributor

@SunnyLeu glad to hear that! Then we will add klook to the default HTTPS filtering exclusions in the next updates

@maxikuzmin maxikuzmin changed the title com.klook app is broken by filtering Add com.klook app to the default HTTPS filtering exclusions Feb 6, 2024
@adguard-bot adguard-bot added the Bug label Feb 6, 2024
@maxikuzmin
Copy link
Contributor

@SunnyLeu could you be more specific, with applications
https://play.google.com/store/apps/details?id=tw.com.thsrc.enterprise
https://play.google.com/store/apps/details?id=com.tplink.tpm5

have you also experienced problems? I'm checking with myself, but there is also no problem even with HTTPS filtering

@SunnyLeu
Copy link

@SunnyLeu could you be more specific, with applications https://play.google.com/store/apps/details?id=tw.com.thsrc.enterprise https://play.google.com/store/apps/details?id=com.tplink.tpm5

have you also experienced problems? I'm checking with myself, but there is also no problem even with HTTPS filtering

https://play.google.com/store/apps/details?id=com.sparkslab.dcardreader
https://play.google.com/store/apps/details?id=grasea.familife
https://play.google.com/store/apps/details?id=tw.net.pic.m.openpoint

I have a lots of apps in my phone, I can't test them all

@maxikuzmin
Copy link
Contributor

@SunnyLeu I asked about those two apps because you listed them in the examples in the issue.

Are those three apps also having problems with HTTPS filtering enabled?

@SunnyLeu
Copy link

Yes, if HTTPS filtering is enabled on those apps, the apps won't able to connect to internet.

@maxikuzmin
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants