Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of license check and filter update requests #574

Closed
vbagirov opened this issue May 23, 2016 · 11 comments
Closed

Limit the number of license check and filter update requests #574

vbagirov opened this issue May 23, 2016 · 11 comments
Assignees
Milestone

Comments

@vbagirov
Copy link
Member

vbagirov commented May 23, 2016

Currently they are too irritating with ~5 notifications a day.

Original request:
https://forum.adguard.com/index.php?threads/adguard-%D0%B4%D0%BB%D1%8F-android-%D0%91%D0%B5%D1%82%D0%B0-%D0%B2%D0%B5%D1%80%D1%81%D0%B8%D1%8F-2-6-23.10581/#post-83803

UPD: we don't have any "license expiring" notifications (why so btw?). So in this issue we'll do another useful thing: limit the number of license check requests.

Usually we do such request once in 12 or 24 hours. The problem is that currently when app is killed and restarted, timer is started over and first license check is scheduled on +5 min.

@vbagirov vbagirov added this to the 2.6 milestone May 23, 2016
@Revertron
Copy link

But this is not our notification :-)
screenshot_2016-05-23-12-20-39
We do not have such icon and text.

@ameshkov
Copy link
Member

ameshkov commented Jun 1, 2016

Huh, do we have any notification?:)

@ameshkov
Copy link
Member

ameshkov commented Jun 1, 2016

Nevertheless, we should limit the number of any requests to our server.

Currently we just do it periodically once in 12 or 24 hours (don't remember then number). The problem is that if our app is killed by Android, timer is started over and first request is scheduled on +5 mins.

@Revertron
Copy link

Nope. I think we should make some :)

@ameshkov
Copy link
Member

ameshkov commented Jun 1, 2016

Haha, nice:)

@ameshkov
Copy link
Member

ameshkov commented Jun 1, 2016

Let's schedule it on v2.7 release.

@Revertron Revertron modified the milestones: 2.7, 2.6 Jun 1, 2016
@ameshkov ameshkov changed the title Make 'license renewal' notifications more rare Limit the number of license check and filter update requests Jun 1, 2016
@ameshkov ameshkov modified the milestones: 2.6, 2.7 Jun 1, 2016
@ameshkov
Copy link
Member

ameshkov commented Jun 1, 2016

@Revertron not this issue, make a separate one.

This one is renamed to "Limit the number of license check and filter update requests"

@Revertron
Copy link

Ah, okay.

@TPS
Copy link
Contributor

TPS commented Jun 3, 2016

My 2¢: If y'all don't mind (especially since #611 will probably increase server load some, anyway), but even 12 hours is probably too long an interval for a manual check. I can sometimes request a filter update 1 hour apart from my last 1, & get an update to several lists. (The English & German lists seem to have frequent updates!) Limiting the automatic checks _only_ would be my preference.

@ameshkov
Copy link
Member

ameshkov commented Jun 3, 2016

@TPS I mean the periodic automatic update check, manual checks have no limitations.

@Revertron
Copy link

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants