New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adguard kills itself on update #696

Closed
ameshkov opened this Issue Jul 18, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@ameshkov
Member

ameshkov commented Jul 18, 2016

Steps to reproduce:

  1. Install previous AG version
  2. Turn autostart OFF in AG settings
  3. Install update and tap "Open" after it
  4. AG won't finish loading and will simply close itself.

Here is what's going on:

22:44:14.819 [main] DEBUG c.a.a.receivers.PackageReceiver - Package receiver received intent Intent { act=android.intent.action.PACKAGE_REPLACED dat=package:com.adguard.android flg=0x4000010 cmp=com.adguard.android/.receivers.PackageReceiver (has extras) }
22:44:14.819 [main] INFO  c.a.a.receivers.PackageReceiver - Package receiver received android.intent.action.PACKAGE_REPLACED for com.adguard.android
22:44:14.820 [main] DEBUG c.a.a.receivers.PackageReceiver - Handling our application update
22:44:14.824 [main] INFO  c.a.android.receivers.BaseReceiver - Autostart is disabled and service is not running, we should exit[/

I guess Adguard should not react that way on its own update. Maybe we should simply ignore it.

@ameshkov ameshkov added the Bug label Jul 18, 2016

@ameshkov ameshkov added this to the 2.7 milestone Jul 18, 2016

@TPS

This comment has been minimized.

Show comment
Hide comment
@TPS

TPS Jul 18, 2016

Contributor

This actually might be correct, per the user. Folks who have an app set to not autostart wouldn't probably want it running just because of an update. I've several apps like this (not AG! 😉) at which I'd be irritated if they remain running/active just because the dev decided to push an update. (I even have those blocked in the AG firewall to give me some notice if they run unexpectedly.)

Contributor

TPS commented Jul 18, 2016

This actually might be correct, per the user. Folks who have an app set to not autostart wouldn't probably want it running just because of an update. I've several apps like this (not AG! 😉) at which I'd be irritated if they remain running/active just because the dev decided to push an update. (I even have those blocked in the AG firewall to give me some notice if they run unexpectedly.)

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Jul 18, 2016

Member

@TPS it will start anyway as receiver is registered in the app manifest.

The other way to fix all these autostart issues is remove all receivers from the app manifest and register them programmatically.

Member

ameshkov commented Jul 18, 2016

@TPS it will start anyway as receiver is registered in the app manifest.

The other way to fix all these autostart issues is remove all receivers from the app manifest and register them programmatically.

@nkartyshov

This comment has been minimized.

Show comment
Hide comment
@nkartyshov

nkartyshov Jul 20, 2016

Member

done

Member

nkartyshov commented Jul 20, 2016

done

@nkartyshov nkartyshov closed this Jul 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment