Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Adguard to AdGuard in the list of DNS #618

Closed
zeezeepiggy opened this issue Jan 24, 2018 · 3 comments
Closed

Change Adguard to AdGuard in the list of DNS #618

zeezeepiggy opened this issue Jan 24, 2018 · 3 comments
Assignees
@IvanIin
Labels
Localization UI
Milestone
2.0.0

Comments

@zeezeepiggy
Copy link

Just some minor tweaks. Can we change Adguard to AdGuard in the list of known DNS?
584f2051-f6cd-402e-b11d-6b8bdab1555c
@lancelot-moon
Copy link

lancelot-moon commented Jan 24, 2018 •
edited
Loading

Simply, even if AdGuard team fixed Adguard to AdGuard, it would become Adguard back after some time.
Or wrong words were back.
So v2.0.0 (128) applied defective English strings from oneskyapp at that time.

It seems that @aalpatkina has solved the issue on oneskyapp.

In Traditional Chinese interface, it applies my translations, so it totally shows AdGuard in app.

Screenshot:

image

@zebrum zebrum added this to the 2.0.0 milestone Jan 31, 2018
@ameshkov ameshkov mentioned this issue Feb 6, 2018
Closed
@zeezeepiggy
Copy link
Author

Some more string that needs updating:

image

Thanks!

@zeezeepiggy
Copy link
Author

zeezeepiggy commented Feb 22, 2018 •
edited
Loading

Fixed in beta 138. So good. I think it’s ready for release or Release Candidate 1 (RC1); not unless show stopper and major bugs are discovered. Thanks team!

image

image 2

@zebrum zebrum closed this as completed Mar 1, 2018
adguard pushed a commit that referenced this issue Jan 22, 2020
@IvanIin
Merge pull request #618 in ADGUARD-IOS/adguard-ios from bug/dns_white…
0a9e765 
…_list_fix to master

* commit 'd4c00df561efb06950c9a9476922c62e93cd4d8a':
  rename one method
  Dns user whitelist does not work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanIin IvanIin

Labels
Localization UI
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@lancelot-moon @zebrum @zeezeepiggy @IvanIin