Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Firefox]clicknupload.org #41

Closed
ghost opened this issue Sep 22, 2017 · 1 comment
Closed

[Firefox]clicknupload.org #41

ghost opened this issue Sep 22, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 22, 2017 •
edited by ghost
Loading

Firefox 55.0.3 x64
Adguard 6.2.400
Popup Blocker 2.1.7
Sample URL for testing: https://clicknupload.org/mqmnl7mnqbsg

Proceed to generate download link.

Issue:
When the final download button is present and you click on it, it opens a new tab, download goes to your browser or download manager and the new blank tab remains as it is.

Expected Behavior:
In chrome, although after clicking the final download button, chrome also opens a new tab but as soon as the download start, that new tab closes by itself.
@theseanl
Copy link
Contributor

theseanl commented Sep 22, 2017 •
edited
Loading

Hi, I tried to reproduce the issue, but this is what I got:

  • When I follow indicated steps with Firefox, a new tab opens but the browser says it can't find a DNS address of the server, and the new tab is not being closed.
  • When I additionally use a VPN, a new tab opens and the new tab is closed as soon as the download starts.

so I couldn't reproduce the issue. I guess it is rather how the browser works by design, than an issue of PopupBlocker. This userscript focuses on preventing opening a new window, it currently does not have any code to close an already opened window.

theseanl pushed a commit that referenced this issue Jun 18, 2018
Merge pull request #41 in EXTENSIONS/popup-blocker from feature/issue…
43d1fa1 
…s/100 to master

Squashed commit of the following:

commit ddfaa2f0fb46112f1115ee7ae28c3ccc7e33eace
Author: seanl-adg <seanl@adguard.com>
Date:   Mon Jun 18 23:11:28 2018 +0900

    Extract numbers to constants; tweak for minifier

commit aa41a0f3a6ce59bcf87674a57146ac6795817b18
Author: seanl-adg <seanl@adguard.com>
Date:   Mon Jun 18 22:50:40 2018 +0900

    Fully fix #45

commit 103e0eb6c4b6f38544364b2fbf2ce5d668ba62b0
Merge: 776e6f2 669c801
Author: seanl-adg <seanl@adguard.com>
Date:   Fri Jun 15 21:35:53 2018 +0900

    Actualize

commit 776e6f268d5d8c0be34b2325a3ba34b021474590
Author: seanl-adg <seanl@adguard.com>
Date:   Fri Jun 15 19:34:34 2018 +0900

    Make it work

commit 611e809a4601b324e08b6949f8cd6d153c75a481
Author: seanl-adg <seanl@adguard.com>
Date:   Fri Jun 15 03:02:10 2018 +0900

    Initial attempt

commit 69c56417970e2019eda07c12e845da171913c6c4
Merge: 3c27461 827e20b
Author: seanl-adg <seanl@adguard.com>
Date:   Tue Jun 12 00:52:32 2018 +0900

    Merge branch 'master' into feature/issues/100

commit 3c27461061fba1c46bb8790961aa7b858d1c2def
Merge: ea6e3bb 636f015
Author: seanl-adg <seanl@adguard.com>
Date:   Fri Jun 8 16:42:42 2018 +0900

    Merge branch 'feature/issues/121' into feature/issues/100

commit 636f01595f5715af8aa51e0836ccbd0ddd20403b
Author: seanl-adg <seanl@adguard.com>
Date:   Fri Jun 8 07:07:26 2018 +0900

    Change dev build url

commit e02ecc6391277a073d4e453d04b68a0ce0f0d67f
Author: seanl-adg <seanl@adguard.com>
Date:   Thu Jun 7 20:41:39 2018 +0900

    change options page url; tweak for closure compiler; update translations from onesky

commit ea6e3bbc3d325ef78d928292e85da465fbc302e7
Author: seanl-adg <seanl@adguard.com>
Date:   Thu Jun 7 12:11:02 2018 +0900

    Attempt to improve overlay detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theseanl