Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4.1.1 #381

Merged
merged 5 commits into from
Jun 15, 2022
Merged

v4.1.1 #381

merged 5 commits into from
Jun 15, 2022

Conversation

AdhocAdam
Copy link
Owner

@AdhocAdam AdhocAdam commented Jun 9, 2022 •
edited

To do:

  • Testing
  • Review
  • Update line PowerShell notes

Changes:

  • All empty PowerShell Catch blocks now contain logging events
  • Get-CiresonPortalAPIToken no longer uses a ConvertTo-SecureString
  • The Assigned User of a Closed Incident cannot correctly [reactivate] it which would result in a New and Related Incident
  • Azure Cloud Instance picker returned a string instead of an enum
  • Removed all trailing whitespace

@AdhocAdam
Get-CiresonPortalAPIToken credential object (#379)
6d89634 
creating a PS Credential object and/or using ConvertTo-SecureString is not necessary to make the API call to retrieve a token
@AdhocAdam
empty catch + parameter typo (#378)
d63a6a9 
there are portions of the connector that define try/catch blocks but don't log any event. While updating these occurrences, also discovered a bug wherein the Assigned User of a Closed Incident cannot correctly trigger a reactivation which would result in a New and Related Work Item.
@AdhocAdam AdhocAdam added this to the 4.x.x milestone Jun 9, 2022
@AdhocAdam AdhocAdam self-assigned this Jun 9, 2022
@AdhocAdam
Azure Cloud Instance, string vs. enum (#382)
3afb2ec 
the enum value should not be contained in quotes as this returns a string instead of the enum object
@AdhocAdam AdhocAdam changed the title 4.x.x v4.1.1 Jun 15, 2022
@AdhocAdam
inline notes (#383)
eb256b6 
updating inline notes for the connector
@AdhocAdam
removing trailing whitespace (#384)
d7fce85 
updating preference in local VSCode to remove trailing whitespace on save
@AdhocAdam AdhocAdam marked this pull request as ready for review June 15, 2022 23:24
@AdhocAdam AdhocAdam merged commit ea1ef55 into primary Jun 15, 2022
@AdhocAdam AdhocAdam deleted the dev branch June 16, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AdhocAdam AdhocAdam

Labels
None yet
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AdhocAdam