Azure Cloud Instance, string vs. enum #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the enum value should not be contained in quotes as this returns a string instead of the enum object
AdhocAdam
added a commit
that referenced
this pull request
Jun 15, 2022
* Get-CiresonPortalAPIToken credential object (#379) creating a PS Credential object and/or using ConvertTo-SecureString is not necessary to make the API call to retrieve a token * empty catch + parameter typo (#378) there are portions of the connector that define try/catch blocks but don't log any event. While updating these occurrences, also discovered a bug wherein the Assigned User of a Closed Incident cannot correctly trigger a reactivation which would result in a New and Related Work Item. * Azure Cloud Instance, string vs. enum (#382) the enum value should not be contained in quotes as this returns a string instead of the enum object * inline notes (#383) updating inline notes for the connector * removing trailing whitespace (#384) updating preference in local VSCode to remove trailing whitespace on save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the enum value should not be contained in quotes as this returns a string instead of the enum object