This repository has been archived by the owner on Jul 24, 2023. It is now read-only.
Update DatbaseUserProvider.php to add missing method #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getModel method was missing and caused issues with some additional packages.
|
What packages in particular is this an issue with? |
|
wildside/userstamps was the one that threw it up initially but I would have
to go back and check on the other ones.
…On 27 March 2017 at 12:14, Steve Bauman ***@***.***> wrote:
What packages in particular is this an issue with?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#287 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAmgpPpIEcGav7vN-EuXVdsYOim2eUyuks5rp5n5gaJpZM4Mp_6R>
.
|
|
Has this code been removed from master? |
|
@designvoid Yes it was. I implemented a This is actually an issue with that package, not Adldap2. They're assuming the method is there, when it adheres to no contract: https://github.com/laravel/framework/blob/5.5/src/Illuminate/Contracts/Auth/UserProvider.php https://github.com/WildSideUK/Laravel-Userstamps/blob/master/src/Userstamps.php#L110-L122 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getModel method was missing and caused issues with some additional packages.