Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtcreator-cdbext: Update links #410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelweghorn
Copy link
Contributor

  • switch from "http://" to "https://" URLs
  • update path to changelogs which changed with qt-creator commit [1] ("Install and ship change logs")

Without these changes, the initial submission
of Qt Creator CDB Extension 13.0.1 to Chocolatey
failed automated validation:

qtcreator-cdbext has failed automated validation.

Requirements

Requirements represent the minimum quality of a package that is
acceptable. When a package version has failed requirements, the package
version requires fixing and/or response by the maintainer. Provided a
Requirement has flagged correctly, it must be fixed before the package
version can be approved. The exact same version should be uploaded
during moderation review.

The MailingListUrl element in the nuspec file should be a valid Url.
Please correct this [More...]

Guidelines

Guidelines are strong suggestions that improve the quality of a package
version. These are considered something to fix for next time to increase
the quality of the package. Over time Guidelines can become
Requirements. A package version can be approved without addressing
Guideline comments but will reduce the quality of the package.

In the ReleaseNotes element of the nuspec file a potentially invalid Url
has been found. Recommendation is to fix this URL [More.]

[1] https://code.qt.io/cgit/qt-creator/qt-creator.git/commit/?id=b364cfde2375b2fa56b97e42346affecd2030080

* switch from "http://" to "https://" URLs
* update path to changelogs which changed with
  qt-creator commit [1] ("Install and ship change logs")

Without these changes, the initial submission
of Qt Creator CDB Extension 13.0.1 to Chocolatey
failed automated validation:

> qtcreator-cdbext has failed automated validation.
>
> # Requirements
>
> Requirements represent the minimum quality of a package that is
> acceptable. When a package version has failed requirements, the package
> version requires fixing and/or response by the maintainer. Provided a
> Requirement has flagged correctly, it must be fixed before the package
> version can be approved. The exact same version should be uploaded
> during moderation review.
>
> The MailingListUrl element in the nuspec file should be a valid Url.
> Please correct this [More...]
>
> # Guidelines
>
> Guidelines are strong suggestions that improve the quality of a package
> version. These are considered something to fix for next time to increase
> the quality of the package. Over time Guidelines can become
> Requirements. A package version can be approved without addressing
> Guideline comments but will reduce the quality of the package.
>
> In the ReleaseNotes element of the nuspec file a potentially invalid Url
> has been found. Recommendation is to fix this URL [More.]

[1] https://code.qt.io/cgit/qt-creator/qt-creator.git/commit/?id=b364cfde2375b2fa56b97e42346affecd2030080
michaelweghorn added a commit to michaelweghorn/chocolatey-packages that referenced this pull request May 8, 2024
Just like [1] does for qtcreator-cdbext, update
links for qtcreator as well:

* switch from "http://" to "https://" URLs
* update path to changelogs which changed with
  qt-creator commit [2] ("Install and ship change logs")

[1] AdmiringWorm#410
[2] https://code.qt.io/cgit/qt-creator/qt-creator.git/commit/?id=b364cfde2375b2fa56b97e42346affecd2030080
@michaelweghorn
Copy link
Contributor Author

The CI failure is because qtcreator 13.0.1 is not available yet; from the log:

  • qtcreator-cdbext - Unable to resolve dependency 'qtcreator': Unable to find a version of 'qtcreator' that is compatible with 'qtcreator-cdbext 13.0.1 constraint: qtcreator (= 13.0.1)'.

This might get unblocked by #411 / after the next submission of the qtcreator package after #411 gets merged, but - from all I can say - it's not an issue in this PR itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant