Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear cache flag checking #190

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Fix clear cache flag checking #190

merged 2 commits into from
Aug 28, 2018

Conversation

ErikGartner
Copy link
Contributor

The flag BUILDPACK_CLEAR_CACHE was checked in an improper way causing problem when the flag exists but is empty.

The new checking method is also more consistent with other flags in the compile file.

@chdsbd
Copy link
Contributor

chdsbd commented Aug 28, 2018

Looks great. Do you mind updating these other two places with your new method?

if [ -n "${BUILDPACK_PRELAUNCH_METEOR+1}" ]; then

if [ -n "${BUILDPACK_VERBOSE+1}" ]; then

@ErikGartner
Copy link
Contributor Author

Done :)

@chdsbd chdsbd merged commit 002f4d3 into AdmitHub:master Aug 28, 2018
@chdsbd
Copy link
Contributor

chdsbd commented Aug 28, 2018

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants