Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailscale security vulnerability #1

Closed
Aubermean opened this issue May 14, 2024 · 12 comments
Closed

Tailscale security vulnerability #1

Aubermean opened this issue May 14, 2024 · 12 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Aubermean
Copy link

Aubermean commented May 14, 2024

With the latest version of Tailscale, you might need to add --stateful-filtering=false - especially if you are using an exit node. See the release notes for v1.66.0

https://github.com/tailscale/tailscale/releases

I don't have an account to post to the forum.

@Admonstrator
Copy link
Owner

This must be done by GL.iNet, the update script does not modify the startup scripts.

@Aubermean
Copy link
Author

GL.iNet does not (and likely will not) provide stable Tailscale support, it'll probably be a century before they update Tailscale, so I thought it would be smarter to report it here. It eluded me for ages today trying to figure out why suddenly everything was broken - hopefully might save someone some time. Thanks for the updater!

@Admonstrator
Copy link
Owner

I'll talk to them to adjust the tailscale integration script.

@Admonstrator Admonstrator reopened this May 14, 2024
@Admonstrator Admonstrator self-assigned this May 14, 2024
@Admonstrator Admonstrator added enhancement New feature or request question Further information is requested labels May 14, 2024
@Aubermean
Copy link
Author

Aubermean commented May 14, 2024

It's only relevant to the latest version, that flag isn't available in older versions. Tailscale did some server side mitigation too but it's unclear if that will have any effect on older versions, or with mixed client versions. I was also having issues after upgrading my macOS Tailscale version while the router version stayed the same. For now Tailscale are just suggesting everyone upgrade in general. The risk in particular is to Linux and site to site networking.

@Admonstrator
Copy link
Owner

Guess it's just Tunnelvision mitigation - which is a risk indeed; but not as bad as people think.

I will think about a way to add the parameter to the script somehow.

@Aubermean
Copy link
Author

Aubermean commented May 14, 2024

The parameter itself is basically disabling their clientside mitigation. Anyway whether or not it is ever actively exploited, the greater issue/frustration/risk is 24 hours of head scratching why suddenly your whole network isn't working properly :)

So I think even just a warning/explainer so people stumble via Google to a solution sooner rather than later, is all the help anyone will need! Upgrading might randomly break things and the solution (until now) was a little burried.

@Admonstrator
Copy link
Owner

So should it be enabled or disabled by default?

Sorry, don't use Tailscale - team Zerotier 😄

@Aubermean
Copy link
Author

For things to work as they used to, site-to-site stuff, in combination with an exit node (they support Mullvad natively) or acting as a exit node... it needs to be set. Without it things won't work. A warning or pointer to this fact, for 1.66 and up, is enough. Failing that hopefully this issue indexed on google will provide a solution. :)

@Aubermean
Copy link
Author

I already found myself googling back to this solution now, as my router rebooted overnight and lost the tailscale set --stateful-filtering=false flag!

To run this on startup, is it best to use /etc/rc.local?

@Admonstrator
Copy link
Owner

I would assume you need to modify /etc/init.d/tailscale and add procd_append_param command --stateful-filtering=false within the start_service() function. But this needs to be tested.

Admonstrator added a commit that referenced this issue May 19, 2024
Admonstrator added a commit that referenced this issue May 19, 2024
@Admonstrator
Copy link
Owner

A fix was integrated to modify the gl_tailscale script - so active exit nodes should work again.

@Admonstrator
Copy link
Owner

I got a confirmation that it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants