Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #3183 removes JackrabbitSessionIWrap and related classes #3184

Conversation

adamcin
Copy link
Contributor

@adamcin adamcin commented Sep 14, 2023

These classes were previously used in the CloseableQueryBuilder api, which was removed for similar reasons (CQBP-84 and CQBP-84-dependencies flagged implementations of @ProviderType interfaces). Removing the entire wrap package is probably the most expedient approach, since none of the contained classes appear to be referenced in the project, and an alternative and CM-supported approach to maintainably wrapping arbitrary interfaces is provided by the JDK in the java.lang.reflect.Proxy class.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #3184 (3b0e230) into master (a75bb29) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3184      +/-   ##
============================================
- Coverage     55.25%   55.12%   -0.13%     
+ Complexity     5434     5376      -58     
============================================
  Files           713      710       -3     
  Lines         29109    29025      -84     
  Branches       3767     3762       -5     
============================================
- Hits          16084    16000      -84     
  Misses        11512    11512              
  Partials       1513     1513              

@davidjgonzalez davidjgonzalez merged commit d9fb0cd into Adobe-Consulting-Services:master Sep 14, 2023
21 checks passed
@adamcin adamcin deleted the issue-3183-remove-iwrap-classes branch September 14, 2023 14:28
YegorKozlov pushed a commit to YegorKozlov/acs-aem-commons that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants