Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adoptopenjdk11-openj9-large.rb #119

Merged
merged 2 commits into from Jun 15, 2019
Merged

Conversation

VonUniGE
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask in a similar way to the existing casks.
  • Added new cask to the README.md
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.

Add adoptopenjdk11-openj9-large.rb on the same model as adoptopenjdk8-openj9-large.rb

This should close #87

@karianna karianna added this to To do in homebrew-openjdk via automation Jun 15, 2019
@karianna karianna added the enhancement New feature or request label Jun 15, 2019
Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna added this to the June 2019 milestone Jun 15, 2019
@karianna karianna merged commit 142caa4 into master Jun 15, 2019
homebrew-openjdk automation moved this from To do to Done Jun 15, 2019
@gdams gdams deleted the adoptopenjdk11-openj9-large branch November 1, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Please add large heap binaries
2 participants