Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getJigsawJDK.sh to the new Jigsaw downlaod page #67

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

lasombra
Copy link

This should fix issue #65

@neomatrix369
Copy link
Member

@lasombra if you want to resolve #66 you ccan already do it

you will have to save this script file with a different name, which will make two script files available in the system:

getJDK.sh
getJigsawJDK.sh

Are you able to get my drift?

Do you want to create a new PR with those changes?

BUILD_NUMBER=$(curl $JDK_DOWNLOAD_HOME_PAGE/ | grep "Most recent build" | awk '{print $4}' | tr -d "</h2>" | grep -oP "jdk\-9\+\K\w+")
JDK_DOWNLOAD_BASE_URL="http://download.java.net/"
JDK_DOWNLOAD_HOME_PAGE="http://jdk.java.net/jigsaw/"
BUILD_NUMBER=$(curl $JDK_DOWNLOAD_HOME_PAGE/ | grep "Most recent build" | awk '{print $4}' | tr -d "</h2>" | perl -nle 'print$& if m{jdk\-9\+\K\w+}')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to test this change on my Ubuntu box before I merge it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I tested on my RHEL/CentOS 6 box and it worked fine.

@lasombra
Copy link
Author

Yeah. Let me work on it.

@neomatrix369
Copy link
Member

neomatrix369 commented Jun 14, 2017

Works fine on my ubuntu box as well - would be great to have some others test it out. But safe to merge now.

Thanks @lasombra, good work, sorry for the delay in reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants