Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

LTS flag is ignored for /v3/assets/version/{version} endpoint #135

Closed
ParkerM opened this issue Mar 29, 2020 · 2 comments · Fixed by #151
Closed

LTS flag is ignored for /v3/assets/version/{version} endpoint #135

ParkerM opened this issue Mar 29, 2020 · 2 comments · Fixed by #151
Assignees
@johnoliver
Labels
bug Something isn't working
Milestone
April 2020

Comments

@ParkerM
Copy link
Member

ParkerM commented Mar 29, 2020

The v3 swagger UI documents an optional lts query filter for the /v3/assets/version/{version} endpoint, but it does not appear to be implemented.

See example query here for versions 8+ with lts=true returning the latest non-lts 14 release. Looks like the query param is defined here but not used during filtering.
@ParkerM
Copy link
Member Author

ParkerM commented Mar 29, 2020

I made a naive attempt at implementing it with this snippet but got lost trying to figure out how to successfully build/run the frontend tests locally.

@ParkerM ParkerM mentioned this issue Mar 29, 2020
Merged
@karianna karianna added the bug Something isn't working label Mar 29, 2020
@karianna karianna added this to the April 2020 milestone Apr 1, 2020
@karianna karianna closed this as completed Apr 1, 2020
@karianna karianna linked a pull request Apr 1, 2020 that will close this issue
Add lts release filter #151
Merged
2 tasks
@ParkerM
Copy link
Member Author

ParkerM commented Apr 2, 2020

Looks like it's working great now, thanks for the help! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnoliver johnoliver

Labels
bug Something isn't working
Projects
None yet
Milestone
April 2020
Development

Successfully merging a pull request may close this issue.

Add lts release filter johnoliver/openjdk-api-v3
3 participants
@karianna @johnoliver @ParkerM