Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

Fix pre version sort order #247

Closed
johnoliver opened this issue Jul 21, 2020 · 2 comments
Closed

Fix pre version sort order #247

johnoliver opened this issue Jul 21, 2020 · 2 comments
Labels
bug Something isn't working good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed help wanted Extra attention is needed
Projects
openjdk-api-v3 Good First Issues
Milestone
November 2020

Comments

@johnoliver
Copy link
Member

Currently in the version sort order something comes after absent for the pre field. According to point 11 in https://semver.org/ absent should come after something.
@karianna karianna added this to To do in openjdk-api-v3 via automation Jul 21, 2020
@karianna karianna added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jul 21, 2020
@karianna karianna added this to To do in Good First Issues Aug 7, 2020
@nickebbitt
Copy link
Contributor

nickebbitt commented Sep 4, 2020 •
edited
Loading

The sort order is driven by the following code: https://github.com/AdoptOpenJDK/openjdk-api-v3/blob/master/adoptopenjdk-api-v3-models/src/main/kotlin/net/adoptopenjdk/api/v3/dataSources/models/Releases.kt#L104

As an example (with fictional version numbers), currently we get:

1.0.0. < 1.0.0-alpha

but it should be:

1.0.0-alpha < 1.0.0.

@nickebbitt
Copy link
Contributor

I think as a starting point adding some tests focused around Release.kt will be useful to demonstrate the existing behaviour.

This can then be used to evolve the sort order to meet the requirements of this issue.

@hendrikebbers hendrikebbers added the good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed label Sep 21, 2020
@hendrikebbers hendrikebbers removed the good first issue Good for newcomers label Oct 19, 2020
johnoliver added a commit to johnoliver/openjdk-api-v3 that referenced this issue Nov 13, 2020
@johnoliver
Set pre sorting to put null last. Fixes AdoptOpenJDK#247
409e590
johnoliver added a commit to johnoliver/openjdk-api-v3 that referenced this issue Nov 13, 2020
@johnoliver
Set pre sorting to put null last. Fixes AdoptOpenJDK#247
8882629
johnoliver added a commit to johnoliver/openjdk-api-v3 that referenced this issue Nov 13, 2020
@johnoliver
Set pre sorting to put null last. Fixes AdoptOpenJDK#247
1c3b5e7
@M-Davies M-Davies linked a pull request Nov 13, 2020 that will close this issue
Set pre sorting to put null last. Fixes #247 #310
Closed
3 tasks
johnoliver added a commit to johnoliver/openjdk-api-v3 that referenced this issue Nov 16, 2020
@johnoliver
Use full version data for filtering rather than semver
7ac2bd4 
Set pre sorting to put null last. Fixes AdoptOpenJDK#247
openjdk-api-v3 automation moved this from To do to Done Nov 17, 2020
Good First Issues automation moved this from To do to Done Nov 17, 2020
@karianna karianna added this to the November 2020 milestone Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue - candidate This label defines that the issues can become a "good first issue" - must be reviewed help wanted Extra attention is needed
Projects
Good First Issues
  
Done
openjdk-api-v3
  
Done
Milestone
November 2020
Development

Successfully merging a pull request may close this issue.

Set pre sorting to put null last. Fixes #247 johnoliver/openjdk-api-v3
4 participants
@karianna @johnoliver @nickebbitt @hendrikebbers