Remove unnecessary complexity for the site banner/notice #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now on staging server here. |
|
@supahgreg Conflict in your Gulp |
There is no point to having JS+XHR calls load a banner/notice fragment for each page (introducing overhead) when the PR process is followed (i.e. the message can be inserted at build time).
|
@karianna Thanks, I've rebased to address the conflict. |
karianna
requested changes
Nov 19, 2018
|
Sure-- I've added an entry to |
karianna
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies things by inserting the banner/notice at build time, rather than on each client page load via https://www.w3schools.com/lib/w3data.js. There is no benefit to dynamically loading
banner.htmlon every page when Prod changes occur through PRs / Jenkins builds.Checklist
npm testpasses