-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left filters - Organise filters and make them visually consistent #36
Comments
@yochannah What about now? http://im-browser-prototype.herokuapp.com/ |
The order is better and I like the colouring of the clear filters button! A few things to improve:
Overall it does already look much better, though! |
@yochannah What about now? Im not very good with this consistency things because I'm more a back-end person 🤣 🤣 |
This is much better! The only thing I'd change is the rounded corners of the separator - just remove the border-radius entirely or set it to 0 and it'd be great. And you're learning front-end stuff very nicely! After this you'll be able to add your L33t front-end skills to your CV ;) |
@yochannah hahahaha 😆 thanks! Done: http://im-browser-prototype.herokuapp.com/ If everything is ok, you can close this issue 😉 |
Can we re-order the filters? Right now we have:
Ideally all buttons that have the same behaviour should have the same colouring and format, and buttons that behave differently should be visually distinct. In this case, GO, dataset, pathway, and organism all have filtering behaviour, whereas Clear filter removes filters.
Could we do something more like:
================== <-- some sort of visual separator here, e.g. a thicker border perhaps
The text was updated successfully, but these errors were encountered: