Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transliteration bug #123

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Fix transliteration bug #123

merged 1 commit into from
Sep 19, 2018

Conversation

Adriandmen
Copy link
Owner

Description

As Kevin Cruijssen pointed out, transliteration does not work properly when one of the parameters is an integer. This is now fixed by replacing is_bitstring with is_single? (which checks whether an element is a string or number) and always casts to a string if this is the case.

Tests are now also added to make sure that this does not happen again.

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #123 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   95.82%   95.81%   -0.01%     
==========================================
  Files          17       17              
  Lines        1723     1722       -1     
==========================================
- Hits         1651     1650       -1     
  Misses         72       72
Impacted Files Coverage Δ
lib/commands/str_commands.ex 91.96% <100%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4352506...209202c. Read the comment docs.

@Adriandmen Adriandmen merged commit 43eacb2 into master Sep 19, 2018
@Adriandmen Adriandmen deleted the fix-transliteration branch September 19, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant