Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rocket not returning to departure location on Earth when returning from space station #1310

Closed
bladeroth opened this issue May 23, 2018 · 3 comments

Comments

@bladeroth
Copy link

Version of Advanced Rocketry

1.4.0

Have you verified this is an issue in the latest unstable build

N.A

Version of LibVulpes

0.2.8

Version of Minecraft

1.12.2

Crash report or log (if applicable)

http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read
Not crashing

Description of the problem

I take off from my base on Earth (overworld) to my space station. I then return back to Earth from the space station and am landing in some random location that I have never been before.

@Kzorith
Copy link

Kzorith commented Jun 30, 2018

I am experiencing the same thing but not quite the same way. I take off to Luna and upon my return I'm brought into Earth at 0x 1y 0z suffocating in stone or burning in lava if I can't switch to creative mode quickly enough. I did have it happen on my trip to Luna once as well but it spawned me under bedrock and I died in the void. Subsequent journeys seem to work ok.

Images attached below.

I've tested this in a single player world with only Adv.Rocketry and libVulpes installed. No changes to the config, it's "out of the box"
Adv. Rocketry 1.4.0-88
libVulpes 0.2.8-32

Update: I regression tested this back to 84. 84 worked properly to Luna and back, bringing me back to Earth over my launch pad for a normal decent. On 85 when I went to Luna the first time, it spawned me under bedrock and I died. Upon a second trip to Luna, it spawned me above the surface for a normal decent. The return to Earth, spawns me in at 0x, 1y 0z as noted above.

2018-06-30_14 24 42
2018-06-30_14 29 14

@dmodoomsirius dmodoomsirius moved this from High priority to Needs triage in Categorized Current Issues/Enhancements Jul 17, 2018
@Kaeteker
Copy link

I'd just like to say that I'm experiencing the exact same bug Kzorith did. I'm playing on FTB Continuum 1.4.1.

When I first went to Luna, I spawned at x0 z0 inside bedrock and suffocated. I launched a rescue attempt, only to find that the rocket had disappeared. I did manage to dig down there and grab my grave though. My first launch back to Earth had the exact same issue, suffocating in bedrock. Subsequent launches all work fine. I'm afraid I'm going to have to make two sacrificial rockets whenever I go to a new place, one to suffocate getting there and one to suffocate getting back before everything works right.

zmaster587 added a commit that referenced this issue Jul 19, 2018
@zmaster587
Copy link
Collaborator

zmaster587 commented Jul 19, 2018

Found the issue, there was an instance where destId's y coordinate was used when there was no previous position stored, since only the x and z coordinates are used then y comes from altitude of orbit from the configuration the previous position's y is always 0. I've changed it to use Configuration.orbit in the patch. It should be good to go for the next build.

Categorized Current Issues/Enhancements automation moved this from Needs triage to Closed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants