Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated validation.php to repair block validation #751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BenFremer
Copy link

The field key prefix change broke block validation. This fixes it. If you can give me an ETA for when this fix or a similar fix for ACF block validation will be in, that'd be appreciated. Thanks!

The field key prefix change broke block validation. This fixes it.
@lgladdy
Copy link
Member

lgladdy commented Nov 17, 2022

@BenFremer Hey Ben, just to confirm... did 6.0.4 introduce this issue? or was it present in 6.0.0?

@danielegiorgis
Copy link

@BenFremer
Thanks, you solved a HUGE problem for me!
to avoid modifying the plugin directly and make the modification independent from it (waiting for the fix), I added the logic in my theme, in a custom method linked to the acf/validate_save_post action.

Thanks again from the bottom of my heart <3

@rvola
Copy link

rvola commented Jul 12, 2023

Good morning,
I confirm that currently version 6.1.7 does not check and does not stop the process of saving the post if a required field is not filled.

The fix works for me

edit
Currently this is fixed ONLY if the sidebar is open on the block with the required fields.

If you add a block with a required field and you simply "update" no error message (required fields) will appear.

@lgladdy
Copy link
Member

lgladdy commented Jul 12, 2023

We're currently working on a complete overhaul to our block editor validation and expect to release full support for every instance later this year in ACF 6.3. We'll keep you updated on our progress and beta availability.

@singhpaul
Copy link

singhpaul commented Jul 12, 2023

We're currently working on a complete overhaul to our block editor validation and expect to release full support for every instance later this year in ACF 6.3. We'll keep you updated on our progress and beta availability.

@lgladdy Will the overhaul also please address the issue with non-block validation we raised in Issue #818 ? 🤞🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants