Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings | search providers are outdated in settings.json #132

Closed
Saidmurod1996 opened this issue Dec 6, 2021 · 1 comment · Fixed by #133
Closed

Settings | search providers are outdated in settings.json #132

Saidmurod1996 opened this issue Dec 6, 2021 · 1 comment · Fixed by #133
Assignees
@Saidmurod1996
Labels
bug Something isn't working high-priority ready-for-review

Comments

@Saidmurod1996
Copy link
Contributor

Saidmurod1996 commented Dec 6, 2021 •
edited
Loading

In settings.json the searchproviders link is different (outdated) than the providers inside update field (introduced by this PR) That is causing a bug Pushpendra mentioned here. Searchproviders link in settings.json file should be changed to new ones.
@Saidmurod1996 Saidmurod1996 added bug Something isn't working high-priority labels Dec 6, 2021
@Saidmurod1996 Saidmurod1996 self-assigned this Dec 6, 2021
Saidmurod1996 added a commit that referenced this issue Dec 6, 2021
@Saidmurod1996
pix-578 #132 update settings.json
481f9db
@Saidmurod1996 Saidmurod1996 mentioned this issue Dec 6, 2021
Merged
Saidmurod1996 added a commit that referenced this issue Dec 6, 2021
@Saidmurod1996
pix-578 #132 update settings.json for main
1801990
@Saidmurod1996 Saidmurod1996 mentioned this issue Dec 6, 2021
Merged
@pushpendraKh
Copy link
Contributor

pushpendraKh commented Dec 7, 2021 •
edited
Loading

@Saidmurod1996 I don't think it's a bug. It was the enhancement that we did to search providers without duplicating entries in search provider (this was done before we introduce the Merge Setting option, AFAIR).

Checkout #53 PR's description and comments.

My bad in recalling it.

@pushpendraKh pushpendraKh mentioned this issue Dec 7, 2021
Merged
jfmdev pushed a commit that referenced this issue Dec 10, 2021
@Saidmurod1996
Issue #132 - Fix outdated values in "settings.json" (#133)
e43c320
@jfmdev jfmdev mentioned this issue Dec 10, 2021
Merged
jfmdev pushed a commit that referenced this issue Dec 10, 2021
@Saidmurod1996
Issue #132 - Fix outdated values in "settings.json" (#134)
ad4e875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Saidmurod1996 Saidmurod1996

Labels
bug Something isn't working high-priority ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pix-578 #132 update settings.json AdvancedThreatAnalytics/threat-analytics-search
2 participants
@pushpendraKh @Saidmurod1996