Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap | Improve/customize theme #4

Closed
jfmdev opened this issue Apr 30, 2021 · 3 comments · Fixed by #75
Closed

Bootstrap | Improve/customize theme #4

jfmdev opened this issue Apr 30, 2021 · 3 comments · Fixed by #75
Labels
enhancement New feature or request
Milestone
v5.2

Comments

@jfmdev
Copy link
Contributor

jfmdev commented Apr 30, 2021

The extension is currently using the default theme of Bootstrap on his pages, which make the pages to look too generic. We should use a different template (or customize the current one) to make the application to look more unique and maybe more alike to https://www.criticalstart.com/

image

Hint: please note that they are several free sites to download templates (like https://startbootstrap.com/themes) or to generate templates (like https://bootstrap.build/).
@jseadragon jseadragon transferred this issue from another repository May 6, 2021
@jfmdev jfmdev added the on-hold label May 6, 2021
@jfmdev jfmdev added this to the v5.1 milestone May 6, 2021
@jfmdev jfmdev added the enhancement New feature or request label May 10, 2021
@jfmdev jfmdev added the estimation-5 5 story points label Jun 3, 2021
@jfmdev jfmdev mentioned this issue Jun 4, 2021
Merged
@jfmdev jfmdev removed the on-hold label Jul 8, 2021
@jfmdev
Copy link
Contributor Author

jfmdev commented Jul 12, 2021 •
edited
Loading

Requirements (for first iteration):

  • Modify the Webpack configuration so SCSS file can be imported.
  • Create a theme.scss file were you import the .scss file from Bootstrap (e.g. @import 'node_modules/bootstrap/scss/bootstrap';).
  • On theme.scss redefine (some) Bootstrap variables for colors and fonts (to make the extension's Options page to look more similar to https://www.criticalstart.com/).
  • Replace import "bootstrap/dist/css/bootstrap.min.css"; by something like import "../styles/theme.css";.

AvazAlimov added a commit that referenced this issue Jul 15, 2021
@AvazAlimov
Issue #4 - Load sass file
c1aeeed
AvazAlimov added a commit that referenced this issue Jul 15, 2021
@AvazAlimov
Issue #4 - Set default font family
6c07e30
AvazAlimov added a commit that referenced this issue Jul 16, 2021
@AvazAlimov
Issue #4 - Redefine few bootstrap colors
5f78d1d
@AvazAlimov AvazAlimov mentioned this issue Jul 16, 2021
Merged
AvazAlimov added a commit that referenced this issue Jul 16, 2021
@AvazAlimov
Issue #4 - Minor fix to package.json
25ba455
jfmdev pushed a commit that referenced this issue Jul 23, 2021
@AvazAlimov
Issue #4 - Custom Bootstrap theming (#75)
17a7d32 
* Issue #4 - Load sass file

* Issue #4 - Set default font family

* Issue #4 - Redefine few bootstrap colors

* Issue #4 - Minor fix to package.json
@jfmdev jfmdev mentioned this issue Jul 23, 2021
Merged
4 tasks
@jfmdev jfmdev closed this as completed Jul 23, 2021
@jfmdev
Copy link
Contributor Author

jfmdev commented Aug 5, 2021

Re-opening for the second iteration of this issue

@jfmdev jfmdev reopened this Aug 5, 2021
@jfmdev jfmdev removed the estimation-5 5 story points label Aug 5, 2021
@jfmdev jfmdev modified the milestones: v5.1, v5.2 Aug 5, 2021
@jfmdev jfmdev closed this as completed Nov 9, 2021
@jfmdev
Copy link
Contributor Author

jfmdev commented Nov 9, 2021

Closing, since later we'll develop a Boostrap's theme for all ATA's web projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v5.2
Development

Successfully merging a pull request may close this issue.

Issue #4 - Custom Bootstrap theming AdvancedThreatAnalytics/threat-analytics-search
2 participants
@jfmdev @AvazAlimov