Rewrite search filter sidebar with React #296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the search filters with React to more easily incorporate the following improvements:
The rewrite should also make it easier for a future PR to no longer load the huge list of options when the page is initially rendered and instead only fetch the big lists (e.g., list of notable items) in batches via AJAX.
This PR also showcases how modern JS like React can be integrated into AdventureLookup without much hassle.