-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adventure editing #25
base: master
Are you sure you want to change the base?
Commits on Jun 13, 2016
-
Add tests for adventure editing
Tests for put requests in AdventureById currently fail.
Configuration menu - View commit details
-
Copy full SHA for 3c3fe6f - Browse repository at this point
Copy the full SHA 3c3fe6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for db80d2e - Browse repository at this point
Copy the full SHA db80d2eView commit details -
Add tests for adventure editing
The AdventureById view remains unchanged, so the put method tests currently fail.
Configuration menu - View commit details
-
Copy full SHA for 95af3d8 - Browse repository at this point
Copy the full SHA 95af3d8View commit details -
Store adventure ID, not object, in an attribute
When accessing the Adventure object directly, we have no QuerySet and so cannot call update(), instead we have to call save(). Storing the adventure ID means we can access the Adventure via filter(). This returns a QuerySet, so we can call update(). Calling update() instead of save() is more efficient and avoids a race condition wherein an object is changed in the database between retrieval and saving.
Configuration menu - View commit details
-
Copy full SHA for d36e061 - Browse repository at this point
Copy the full SHA d36e061View commit details -
Add adventure editing via PUT requests
No attempt is made at authentication, nor at proper CSRF-handling. The assumption is made that authentication will be handled by a parent view.
Configuration menu - View commit details
-
Copy full SHA for 99272cf - Browse repository at this point
Copy the full SHA 99272cfView commit details -
Merge branch 'edit-adventures' with remote branch
Local repo was screwed up. This brings the local and remote repos to the same point.
Configuration menu - View commit details
-
Copy full SHA for 7b1f82a - Browse repository at this point
Copy the full SHA 7b1f82aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bf6fcb - Browse repository at this point
Copy the full SHA 3bf6fcbView commit details