Including all notification codes as constants #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Got all notification codes from : https://docs.adyen.com/development-resources/notifications/understand-notifications#event-codes - Created tests for cancelation and chageback events - Dedup of test code at NotificationTest class
RicardoRFaria
requested review from
AlexandrosMor,
martinsrenato,
rikterbeek and
rkewlani
as code owners
andrei-dediu
approved these changes
Mar 10, 2020
andrei-dediu
approved these changes
Mar 10, 2020
martinsrenato
approved these changes
Mar 18, 2020
AlexandrosMor
approved these changes
Mar 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested scenarios
Parser of cancellation and chargeback events
Fixed issue:
#307
Question
Do really make sense create tests for every event code? Looking at
NotificationRequestItem.class, sounds like you are just testing GSON and the contract of the event.If it's important to test every case, could you guys provide JSON examples? It is hard to find examples for every event at the site.