Release version 6.0.0 #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added missing messageVersion field to ThreeDS2Result * Amended hashcode * Added test case for ThreeDS2Result fields Co-authored-by: Suleman Chaudhry <Suleman.Chaudhry@net-a-porter.com>
- Got all notification codes from : https://docs.adyen.com/development-resources/notifications/understand-notifications#event-codes - Created tests for cancelation and chageback events - Dedup of test code at NotificationTest class Co-authored-by: Ricardo Faria <ricardo.faria@ifood.com.br>
I encountered two problems when trying to send a TechnicalCancelRequest using the Modification service: - ClassCastException when calling setters on TechnicalCancelRequest because it's incorrectly trying to cast it as a CancelOrRefundRequest - Missing "response" field when deserializing the result because the ModificationResult was missing an enum for "[technical-cancel-received]"
Technical cancel api fix
Updated toString and hash of PaymentsRequest. Fixed mispelled property name in PaymentMethodRequest.
* Updated PaymentResult.ResultCodeEnum possible values * Update PaymentResult.java
* Improve minor code changes * Fix possible NPEs * Replace star import with class import Co-authored-by: Simon Michel <simon@simons-mbp.speedport_w_724v_typ_a_05011603_06_003>
* PW-2291: accept all 20x resultcodes * PW-2291: fix condition * PW-2291: refactor * PW-2291: change to Integer
…#335) * PW-1674: remove "value" and add correct value field according to nexo * PW-1674: fix '>' character failing tests
The java api library was not compatible anymore with the web api since the web api does return a phone number object instead of the fullPhoneNumber field.
rikterbeek
requested review from
AlexandrosMor,
martinsrenato and
rkewlani
as code owners
|
This pull request fixes 7 alerts when merging 09211cc into a6e0baa - view on LGTM.com fixed alerts:
|
|
This pull request fixes 7 alerts when merging 7a1d763 into a6e0baa - view on LGTM.com fixed alerts:
|
rkewlani
approved these changes
Apr 28, 2020
AlexandrosMor
approved these changes
Apr 28, 2020
Aleffio
approved these changes
Apr 28, 2020
martinsrenato
approved these changes
Apr 29, 2020
andrei-dediu
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#320 Including all notification codes as constants
#322 Technical Cancel API fix
#323 Added the store field to the PaymentsRequest and PaymentMethodsRequest
#324 Improve minor code changes
#326 Remove ThreeDS2Result from checkout
#328 Updated PaymentResult.ResultCodeEnum possible values
#331 Added tests with encrypted card details
#332 Adds phone number to AccountHolderDetails
#334 Accept all 20x resultcodes
#335 Remove "value" and add correct value field according to nexo
#337 Add "EXTERNAL" to possible recurring.contract values