Technical cancel api fix #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaneman
requested review from
AlexandrosMor,
martinsrenato,
rikterbeek and
rkewlani
as code owners
I encountered two problems when trying to send a TechnicalCancelRequest using the Modification service: - ClassCastException when calling setters on TechnicalCancelRequest because it's incorrectly trying to cast it as a CancelOrRefundRequest - Missing "response" field when deserializing the result because the ModificationResult was missing an enum for "[technical-cancel-received]"
dbaneman
force-pushed
the
technical-cancel-api-fix
branch
from
c1e6038
to
4b348cc
Compare
|
Hello @dbaneman, We would like to thank you for the PR, is it possible to add unit test related to your code? regards, |
rikterbeek
approved these changes
Mar 24, 2020
andrei-dediu
approved these changes
Mar 24, 2020
|
Hi @dbaneman, Again thanks for the PR! We have merged the code we will add some extra testing on our end to spot the inconsistencies. Regards, |
|
Great -- thanks for the fast response on this, @rikterbeek ! One last note on this: you may also want to add "TECHNICAL_CANCEL" to the list of event codes on https://docs.adyen.com/development-resources/notifications/understand-notifications#event-codes Best, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a couple small issues with the technical-cancel API.
Tested scenarios
After vendoring this change into our application, I successfully sent a technical-cancel request and saw the expected response code in the API response.