PW-1705 #323
Merged
PW-1705 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-dediu
requested review from
AlexandrosMor,
martinsrenato,
rikterbeek and
rkewlani
as code owners
AlexandrosMor
previously approved these changes
Mar 25, 2020
rkewlani
suggested changes
Mar 25, 2020
| @@ -87,6 +87,9 @@ | |||
| @SerializedName("threeDSAuthenticationOnly") | |||
| private Boolean threeDSAuthenticationOnly = null; | |||
|
|
|||
| @SerializedName("store") | |||
| private String store = null; | |||
There was a problem hiding this comment.
Please update equals() and toString() methods to add this field
There was a problem hiding this comment.
Nice catch, updated.
Also, the applicationInfo serialised annotation was mispelled, updated that as well.
Updated toString and hash of PaymentsRequest. Fixed mispelled property name in PaymentMethodRequest.
martinsrenato
previously approved these changes
Mar 25, 2020
rkewlani
previously approved these changes
Mar 25, 2020
andrei-dediu
dismissed stale reviews from rkewlani and martinsrenato
via
c220aa0
AlexandrosMor
previously approved these changes
Mar 27, 2020
martinsrenato
approved these changes
Mar 27, 2020
rkewlani
approved these changes
Mar 27, 2020
rikterbeek
approved these changes
Mar 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the store field to the PaymentsRequest and PaymentMethodsRequest for the Checkout API.
Description
Added the store property field to the PaymentsRequest and PaymentMethodsRequest manually as it was requested for the ticket. The OpenAPI models have not yet been updated with these fields so we can not generate them yet.
Tested scenarios
None.
Fixed issue:
PW-1705