Adds phone number to AccountHolderDetails #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The java api library was not compatible anymore with the web api since the web api does return a phone number object instead of the fullPhoneNumber field.
viZu
requested review from
AlexandrosMor,
andrei-dediu,
martinsrenato,
rikterbeek and
rkewlani
as code owners
martinsrenato
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Hi @viZu ,
Thanks for raising this issue.
Indeed, this field was wrongly removed when we updated the Account API to v5. A bug on our internal documentation marked this field as removed, but this should only happen on v6 of the API (which we should make available on this library soon).For now the fields is still returned and your contribution is valid.
Regards,
Renato
Adyen
Aleffio
approved these changes
Apr 21, 2020
|
Hi @viZu , I just merged your changes, they will be included on our next release, which should happen soon. Regards, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The java api library was not compatible anymore with the
web api since the web api does return a phone number object
instead of the fullPhoneNumber field.
Tested scenarios
No new test scenarios since it only adds a field and getter/setter to the AccountHolderDetails
Fixed issue: