[PW-7208] Update adyen method call for virtual products #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrosMor
requested review from
acampos1916,
rikterbeek,
peterojo,
Morerice,
michaelpaul,
candemiralp and
RokPopov
as code owners
Morerice
previously approved these changes
Sep 19, 2022
michaelpaul
previously approved these changes
Sep 19, 2022
RokPopov
previously approved these changes
Sep 19, 2022
candemiralp
previously approved these changes
Sep 20, 2022
acampos1916
reviewed
Sep 20, 2022
AlexandrosMor
dismissed stale reviews from candemiralp, RokPopov, michaelpaul, and Morerice
via
9124683
Merged
candemiralp
approved these changes
Sep 21, 2022
peterojo
approved these changes
Sep 21, 2022
peterojo
approved these changes
Sep 21, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
RokPopov
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Update adyen method call for virtual products * Remove checking for shipping adress before doing the payment methods call Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com>
RokPopov
added a commit
that referenced
this pull request
Sep 28, 2022
* add test for isFullAmountFinalized - immediate capture * [PW-7208] Update adyen method call for virtual products (#1716) * Update adyen method call for virtual products * Remove checking for shipping adress before doing the payment methods call Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com> * Version bump 8.6.0 * [PW-7147] Handle Capture Requests triggered from Customer Area (#1714) * create adyen and magento invoice from webhook if captured manually in CA * remove code smells * throw exception if adyen_invoice null and canInvoice is false * throw exception in case of CA initiated partial manual capture * use AdyenWebhookException instead of a generic one * rename method Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> * use renamed method Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> * update $adyenInvoice Co-authored-by: Michael Paul <michael.paul@adyen.com> * resolve merge conflicts * get rid of code smells * remove final code smells * use $adyenInvoiceObject instead of $adyenInvoice * remove code smell Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> Co-authored-by: Michael Paul <michael.paul@adyen.com> Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com> * refactor the way we are building mock AdyenOrderPaymentHelper, fix testCreateAdyenOrderPayment * setup testIsFullAmountAuthorized() * add testIsFullAmountNotFinalizedManualCapture() and testIsFullAmountAuthorized() * setup testRefundAdyenOrderPayment() * remove code smells * align params - code smell * fix testRefundAdyenOrderPayment Co-authored-by: Alexandros Moraitis <alexandros.moraitis@adyen.com> Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com> Co-authored-by: peterojo <peter.ojo@adyen.com> Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> Co-authored-by: Michael Paul <michael.paul@adyen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The payment method call was not triggered for virtual products as the shipping information was missing.
It should be called for products without shipping information as well
Tested scenarios
Co-authored-by: @candemiralp