[PW-7032] Add unit tests for Adyen Order Payment helper #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update adyen method call for virtual products * Remove checking for shipping adress before doing the payment methods call Co-authored-by: Jeantwan Teuma <Morerice@users.noreply.github.com> Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com>
* create adyen and magento invoice from webhook if captured manually in CA * remove code smells * throw exception if adyen_invoice null and canInvoice is false * throw exception in case of CA initiated partial manual capture * use AdyenWebhookException instead of a generic one * rename method Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> * use renamed method Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> * update $adyenInvoice Co-authored-by: Michael Paul <michael.paul@adyen.com> * resolve merge conflicts * get rid of code smells * remove final code smells * use $adyenInvoiceObject instead of $adyenInvoice * remove code smell Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> Co-authored-by: Michael Paul <michael.paul@adyen.com> Co-authored-by: Peter Ojo <peterojo@users.noreply.github.com>
…stCreateAdyenOrderPayment
RokPopov
changed the title
michaelpaul
approved these changes
Sep 28, 2022
candemiralp
approved these changes
Sep 28, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will increase the unit test coverage of the Adyen Order Payment helper class.
Added unit tests for the following methods:
/Helper/AdyenOrderHelper::isFullAmountFinalized/Helper/AdyenOrderHelper::isFullAmountAuthorized/Helper/AdyenOrderHelper::refundAdyenOrderPayment