Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error when processing webhook for recurringPayment-account-xxx received #1021

Closed
nsquar3d opened this issue Dec 1, 2023 · 1 comment

Comments

@nsquar3d
Copy link

nsquar3d commented Dec 1, 2023

When new recurring payment instruments are added to a users account, an authorization webhook notification is received with the following format for the orderId: recurringPayment-account-timestamp

When this webhook gets processed, some string manipulation is done resulting in a final orderId of "account". This appears to then skip the logic block in lines 80 - 85 of handleCustomObject.js, which cases the webhook job to throw fatal errors.

To Reproduce
Steps to reproduce the behavior:

  1. Add a new recurring payment method in a user's account
  2. Run the webhook job to process the adyen notifications
  3. Open the webhook log file and notice the errors for the following:
    Process Notification for not existing order recurringPayment-account-20231201044933843 received

Expected behavior
This webhook notification should be skipped / marked as processed

Additional context
Using version 23.2.1

@zenit2001
Copy link
Contributor

Hi @nsquar3d ,

Thank you for reporting this issue.
We have fixed it in this PR and included it in the release v23.3.1.

With kind regards,
Zenit
Adyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants