Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFI-532] Recurring webhook not processing #1022

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[SFI-532] Recurring webhook not processing #1022

merged 1 commit into from
Dec 4, 2023

Conversation

zenit2001
Copy link
Contributor

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    When doing zero auth transactions, the webhook is not being processed, throwing an error log.
  • What existing problem does this pull request solve?
    It satisfies the logic for skipping the webhook notification and clearing the custom objects.

Fixed issue: SFI-532

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@zenit2001 zenit2001 added the fix Fixes a bug label Dec 4, 2023
@zenit2001 zenit2001 marked this pull request as ready for review December 4, 2023 13:38
@zenit2001 zenit2001 merged commit 8d01bc4 into develop Dec 4, 2023
13 of 15 checks passed
@zenit2001 zenit2001 deleted the bugfix/SFI-532-recurring-webhook-not-processing branch December 4, 2023 13:53
@zenit2001 zenit2001 mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amihajlovski amihajlovski amihajlovski approved these changes

@shanikantsingh shanikantsingh shanikantsingh approved these changes

@maassenbas maassenbas Awaiting requested review from maassenbas maassenbas is a code owner

Assignees
No one assigned
Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zenit2001 @amihajlovski @shanikantsingh