Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFI-360] Encode the query string for amazonpay #1010

Merged
merged 2 commits into from
Nov 15, 2023
Merged

[SFI-360] Encode the query string for amazonpay #1010

merged 2 commits into from
Nov 15, 2023

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented Nov 8, 2023 •
edited
Loading

  • What is the motivation for this change?
    This PR encodes the query string for amazon pay.

Fixed issue: SFI-360

AbdullahWins
AbdullahWins reviewed Nov 8, 2023
View reviewed changes
Copy link

@AbdullahWins AbdullahWins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!

@zenit2001 zenit2001 added the fix Fixes a bug label Nov 8, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zenit2001 zenit2001 marked this pull request as ready for review November 8, 2023 14:46
@zenit2001 zenit2001 merged commit b230755 into develop Nov 15, 2023
14 of 17 checks passed
@zenit2001 zenit2001 deleted the bugfix/SFI-360-amazonpay_queryparams branch November 15, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdullahWins AbdullahWins AbdullahWins left review comments

@amihajlovski amihajlovski amihajlovski approved these changes

@shanikantsingh shanikantsingh shanikantsingh approved these changes

@maassenbas maassenbas Awaiting requested review from maassenbas maassenbas is a code owner

Assignees
No one assigned
Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zenit2001 @amihajlovski @shanikantsingh @AbdullahWins