[SFI-415] setPaymentTransactionType not working for giftcards #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
zenit2001
requested review from
maassenbas,
amihajlovski and
shanikantsingh
as code owners
amihajlovski
approved these changes
Nov 21, 2023
shanikantsingh
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes proposed in this pull request:
This PR adjusts the setPaymentTransactionType to cover the scenarios when giftcards are being used, and gives the possibility to treat them as SALE payment methods when synchronizing with OMS. It also fixes the extra space issue when the metadata string is edited from BM config page, which before was leading to the last SALE payment method to be missed.
This PR enables the giftcards to be treated as SALE payment methods and fixes the parsing issue when editing the BM fields where SALE payment methods are saved.
Fixed issue: SFI-415