Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFI-436] Applepay billing address not being submitted #1016

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

zenit2001
Copy link
Contributor

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    When making an ApplePay payment through end of checkout flow and filling in a different shipping and billing address, the billing address does not update since we don't submit the billing form onSubmit().
  • What existing problem does this pull request solve?
    This PR submits the billing form onSubmit() event of apple pay component, which will correctly update the order details.

Fixed issue:

Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zenit2001 zenit2001 added the fix Fixes a bug label Nov 23, 2023
@zenit2001 zenit2001 marked this pull request as ready for review November 24, 2023 13:15
@zenit2001 zenit2001 merged commit 864a100 into develop Nov 29, 2023
14 of 17 checks passed
@zenit2001 zenit2001 deleted the bugfix/SFI-436-applepay_billing_address branch November 29, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants