Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFI-421] Notifications failing for bundled products #1018

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

zenit2001
Copy link
Contributor

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    This PR uses the session currency to retrieve the currencyCode for initializing the session for bundled products. The previous implementation was breaking the notifications.
  • What existing problem does this pull request solve?
    The notifications are properly processed for every order.

Fixed issue: [SFI-421]

@zenit2001 zenit2001 changed the base branch from main to develop November 27, 2023 12:46
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zenit2001 zenit2001 added the fix Fixes a bug label Nov 27, 2023
@zenit2001 zenit2001 marked this pull request as ready for review November 27, 2023 14:05
@zenit2001 zenit2001 merged commit 1962466 into develop Nov 29, 2023
14 of 17 checks passed
@zenit2001 zenit2001 deleted the bugfix/SFI-421-session_fails_for_bundled_products branch November 29, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants