Installments add rule button not rendering properly #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t was overwriting the text
…t was overwriting the text
zenit2001
changed the title
zenit2001
requested review from
maassenbas,
amihajlovski and
shanikantsingh
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
amihajlovski
approved these changes
Dec 5, 2023
ShubhamVijaivargiya
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Add Rule button for installments overwrites the text when there are no installment options setup.
It positions the Add Rule button in a static place, where it will not overwrite the text.
It also adds a validation in case installments are not enabled, to not render them in the component.
Fixed issue: