Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFI-556] Level 2/3 data only on scheme requests #1025

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[SFI-556] Level 2/3 data only on scheme requests #1025

merged 1 commit into from
Dec 14, 2023

Conversation

zenit2001
Copy link
Contributor

Summary

  • What is the motivation for this change?
    Level 2/3 data is being included in all payment requests in case it is enabled.
  • What existing problem does this pull request solve?
    This PR includes the level 2/3 data only in case scheme payment methods are being used.

Tested scenarios

Description of tested scenarios:

  • Scheme payment with level 2/3 data enabled
  • Alternative payment method with level 2/3 data enabled
  • Scheme payment with level 2/3 data disabled

Fixed issue: SFI-556

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zenit2001 zenit2001 added the fix Fixes a bug label Dec 6, 2023
@zenit2001 zenit2001 marked this pull request as ready for review December 7, 2023 09:36
shanikantsingh
shanikantsingh reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@shanikantsingh shanikantsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this fix be also applied in adyenSessions.js?

@zenit2001
Copy link
Contributor Author

should this fix be also applied in adyenSessions.js?

In adyenSessions.js, we don't have the payment method selected, since we use it only for rendering the payment methods and not for sending the payment request.

@zenit2001 zenit2001 merged commit 53e1e81 into develop Dec 14, 2023
15 checks passed
@zenit2001 zenit2001 deleted the improvement/SFI-556-level23-data-only-for-schemes branch December 14, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amihajlovski amihajlovski amihajlovski approved these changes

@shanikantsingh shanikantsingh shanikantsingh approved these changes

@maassenbas maassenbas Awaiting requested review from maassenbas maassenbas is a code owner

Assignees
No one assigned
Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zenit2001 @amihajlovski @shanikantsingh