Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFI-398] Decoupled SG code from SFRA #1036

Merged
merged 4 commits into from
Jan 17, 2024
Merged

[SFI-398] Decoupled SG code from SFRA #1036

merged 4 commits into from
Jan 17, 2024

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented Jan 15, 2024 •
edited
Loading

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Decoupling SiteGenesis code from SFRA
  • What existing problem does this pull request solve?
    SiteGenesis code is not part of the branch anymore.

Tested scenarios

Description of tested scenarios:

  • Manually triggered SFRA E2E tests
  • Manually tested the service calls changes

Fixed issue: SFI-398

@zenit2001 zenit2001 marked this pull request as ready for review January 15, 2024 15:21
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zenit2001 zenit2001 merged commit 8c84dc5 into develop Jan 17, 2024
15 checks passed
@zenit2001 zenit2001 deleted the improvement/SFI-398-decouple_sg_code_from_SFRA branch January 17, 2024 13:36
@zenit2001 zenit2001 added the refactor Refactors existing code label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amihajlovski amihajlovski amihajlovski approved these changes

@shanikantsingh shanikantsingh shanikantsingh approved these changes

@maassenbas maassenbas Awaiting requested review from maassenbas maassenbas is a code owner

Assignees
No one assigned
Labels
refactor Refactors existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zenit2001 @amihajlovski @shanikantsingh